summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2015-10-26path-util: minor coding style fixLennart Poettering
We usually avoid relying on C's degrade-to-boolean functionality when comparing numerical variables with 0. We use it only for pointers and actual booleans.
2015-10-26core: rename SmackFileSystemRoot= to SmackFileSystemRootLabel=Lennart Poettering
That way it's in sync with the other SMACK label settings. https://github.com/systemd/systemd/pull/1664#issuecomment-150891270
2015-10-26user-util: never hand out or accept invalid UIDsLennart Poettering
libc isn't that strict, but it's a good idea if we are, to not create confusion around invalid user ids.
2015-10-26util: remove lookup_uid(), replace by uid_to_name()Lennart Poettering
So far we had two pretty much identical calls in user-util.[ch]: lookup_uid() and uid_to_name(). Get rid of the former, in favour of the latter, and while we are at it, rewrite it, to use getpwuid_r() correctly, inside an allocation loop, as POSIX intended.
2015-10-26user-util: simplify uid parsing a bitLennart Poettering
2015-10-26util-lib: split out user/group/uid/gid calls into user-util.[ch]Lennart Poettering
2015-10-26util-lib: split out IO related calls to io-util.[ch]Lennart Poettering
2015-10-26Merge pull request #1674 from evverx/run-fix-couldnot-find-executableLennart Poettering
run: fix "couldn't find executable" for the existing executables
2015-10-25run: fix "couldn't find executable" for the existing executablesEvgeny Vereshchagin
Fixes: #1672
2015-10-25test: "today UTC" is not always "today UTC"Hristo Venev
On Oct 25 2015 in EET/EEST there is a UTC+3->UTC+2 transition. This means that the representation of "today UTC" as local time is ambiguous.
2015-10-25basic: use the return value of endswithHristo Venev
It returns the position where the suffix begins, which can be used for strndup to extract the prefix without calling strlen.
2015-10-25Merge pull request #1668 from ssahani/net1Tom Gundersen
networkd: fix asserts
2015-10-25Merge pull request #1654 from poettering/util-libTom Gundersen
Various changes to src/basic/
2015-10-25Merge pull request #1667 from evverx/run-protect-systemLennart Poettering
systemd-run can launch units with ProtectSystem
2015-10-25util-lib: move formats-util.h from shared/ to basic/Lennart Poettering
It's only a header file, definining format strings for basic system types, hence it should be in src/basic/, not src/shared/.
2015-10-25util-lib: split out fd-related operations into fd-util.[ch]Lennart Poettering
There are more than enough to deserve their own .c file, hence move them over.
2015-10-25Merge pull request #1663 from poettering/journal-compress-fixZbigniew Jędrzejewski-Szmek
journal: fix error handling when compressing journal objects
2015-10-25vxlan: fix assertSusant Sahani
2015-10-25veth: fix assertSusant Sahani
2015-10-25ipvlan: fix assertSusant Sahani
2015-10-25bond: fix assertSusant Sahani
2015-10-25vlan: fix assertSusant Sahani
2015-10-24run: can launch units with ProtectSystemEvgeny Vereshchagin
2015-10-24sd-*.h: clean up exported (or to-be-exported) header filesLennart Poettering
Exported header files should not include internal headers. Fix that. Exported header files should not use the bool type. So far we opted to stick to C89 for exported headers, and hence use "int" for bools in them. Continue to do so. Exported header files should have #include lines for everything they use including inttypes.h and sys/types.h, so that they may be included in any order. Exported header files should have C++ guards, hence add them. Exported header files should not use gcc extensions like #pragma once, get rid of it.
2015-10-24util: move logind_running() to login-util.[ch]Lennart Poettering
2015-10-24core: various small fixes to unit-printfEvgeny Vereshchagin
* check memory allocation errors in specifier_cgroup_slice * %I doesn't fail for non-instantiated units (%i doesn't fail too) * EOPNOTSUPP for consistency
2015-10-24util-lib: split our string related calls from util.[ch] into its own file ↵Lennart Poettering
string-util.[ch] There are more than enough calls doing string manipulations to deserve its own files, hence do something about it. This patch also sorts the #include blocks of all files that needed to be updated, according to the sorting suggestions from CODING_STYLE. Since pretty much every file needs our string manipulation functions this effectively means that most files have sorted #include blocks now. Also touches a few unrelated include files.
2015-10-24util: split out escaping code into escape.[ch]Lennart Poettering
This really deserves its own file, given how much code this is now.
2015-10-24util-lib: rework extract_first_word_and_warn() a bitLennart Poettering
- Really warn in all error cases, not just some. We need to make sure that all errors are logged to not confuse the user. - Explicitly check for EINVAL error code before claiming anything about invalid escapes, could be ENOMEM after all.
2015-10-24util: split out extract_first_word() and related calls into extract-word.[ch]Lennart Poettering
This is quite a lot of code these days, hence move it to its own source file.
2015-10-24path-util: unify how we process paths specified on the command lineLennart Poettering
Let's introduce a common function that makes relative paths absolute and warns about any errors while doing so.
2015-10-24util-lib: get_current_dir_name() can return errors other than ENOMEMLennart Poettering
get_current_dir_name() can return a variety of errors, not just ENOMEM, hence don't blindly turn its errors to ENOMEM, but return correct errors in path_make_absolute_cwd(). This trickles down into a couple of other functions, some of which receive unrelated minor fixes too with this commit.
2015-10-24path-util: rework find_binary(), fsck_exists() and mkfs_exists()Lennart Poettering
Modernize the code a bit: - Get rid of FOREACH_WORD_SEPARATOR() loop in favour of a extract_first_word() loop. - Remove find_binary()'s "local" flag. It's not reasonably possible to look for binaries on remote systems, we hence should not pretend we could. - When we cannot find a suitable binary, return the last error returned from access() rather than ENOENT unconditionally. - Rework fsck_exists() and mkfs_exists() to return 1 on success, 0 if the implementation is missing and negative on real errors. This is more like we do it in other functions. - Make sure we also detect direct fsck symlinks to "true", rather than just absolute ones to /bin/true.
2015-10-24journal: irrelevant coding style fixesLennart Poettering
2015-10-24mount: add new SmackFileSystemRoot= setting for mount unitSangjung Woo
This option specifies the label to assign the root of the file system if it lacks the Smack extended attribute. Note that this option will be ignored if kernel does not support the Smack feature by runtime checking.
2015-10-24journal: fix error handling when compressing journal objectsLennart Poettering
Let's make sure we handle compression errors properly, and don't misunderstand an error for success. Also, let's actually compress things if lz4 is enabled. Fixes #1662.
2015-10-24Merge pull request #1657 from phomes/tmpfiles-simplificationLennart Poettering
tmpfiles: simplify mountpoint detection
2015-10-24Merge pull request #1659 from vcaputo/journal_verify_envalidLennart Poettering
journal: s/Envalid/Invalid/
2015-10-23journal: s/Envalid/Invalid/Vito Caputo
2015-10-23tmpfiles: simplify mountpoint detectionThomas Hindoe Paaboel Andersen
No functional change. Just a simplification. A || (!A && B) is the same as A || B Introduced in 78a92a5a2306709e4587e332728a76901323ade9
2015-10-23Merge pull request #1653 from keszybz/lz4-compress-timeLennart Poettering
Limit test-compress-benchmark to approx. 12 s of runtime
2015-10-23test-compress-benchmark: properly initialize bufferZbigniew Jędrzejewski-Szmek
We were compressing unitialized memory, which should not result in any problems, but is inelegant.
2015-10-23test-compress-benchmark: limit default runtime to 2 seconds per subtestZbigniew Jędrzejewski-Szmek
If both lz4 and xz are enabled, this results in a limit of 2×3×2 s ~= 12 s runtime. Previous implementation started with really small buffer sizes. When combined with a short time limit this resulteded in abysmal results for xz. It seems that the initialization overead is really significant for small buffers. Since xz will not be used by default anymore, this does not seem worth fixing. Instead buffer sizes are changed to run a pseudo-random non-repeating pattern. This should allow reasonable testing for all buffer sizes. For testing, both runtime and the buffer size seed can be specified on the command line. Sufficiently large runtime allows all buffer sizes up to 1MB to be tested.
2015-10-23Merge pull request #1652 from filbranden/extract1Lennart Poettering
util: Replace state with separate booleans in extract_first_word
2015-10-23Merge pull request #1647 from evverx/use-extract-in-namespace-parsingLennart Poettering
core: use extract_first_word for namespace parsing
2015-10-23Merge pull request #1648 from evverx/clarify-journalctl-quiet-optionLennart Poettering
journalctl: clarify -q option
2015-10-23Merge pull request #1641 from poettering/btrfs-quotaDaniel Mack
btrfs quota beef up and various other unrelated changes
2015-10-22util: Replace state with separate booleans in extract_first_wordFilipe Brandenburger
This simplifies the logic and uniformizes the way single and double quotes are handled. In the end, the code is about 40 lines shorter. Tested by running the excellent test cases from test-util. Also installed the systemd binaries including this patch and booted a system with it, everything looked normal.
2015-10-22journalctl: clarify -q optionEvgeny Vereshchagin
-q suppresses info messages too
2015-10-22core: use extract_first_word for namespace parsingEvgeny Vereshchagin
see https://github.com/systemd/systemd/pull/1632#issuecomment-149903791 We should port this loop over to extract_first_word(), too.