Age | Commit message (Collapse) | Author | |
---|---|---|---|
2014-11-28 | treewide: use log_*_errno whenever %m is in the format string | Michal Schmidt | |
If the format string contains %m, clearly errno must have a meaningful value, so we might as well use log_*_errno to have ERRNO= logged. Using: find . -name '*.[ch]' | xargs sed -r -i -e \ 's/log_(debug|info|notice|warning|error|emergency)\((".*%m.*")/log_\1_errno(errno, \2/' Plus some whitespace, linewrap, and indent adjustments. | |||
2014-11-28 | core: fix return value in error path after sd_event_add_io() failure | Michal Schmidt | |
sd_event_add_io() does not set errno, it returns negative errno. Noticed during log_*_errno conversions. | |||
2014-11-28 | treewide: a few more log_*_errno + return simplifications | Michal Schmidt | |
The one in tmpfiles.c:create_item() even looks like it fixes a bug. | |||
2014-11-28 | treewide: yet more log_*_errno + return simplifications | Michal Schmidt | |
Using: find . -name '*.[ch]' | while read f; do perl -i.mmm -e \ 'local $/; local $_=<>; s/(if\s*\([^\n]+\))\s*{\n(\s*)(log_[a-z_]*_errno\(\s*([->a-zA-Z_]+)\s*,[^;]+);\s*return\s+\g4;\s+}/\1\n\2return \3;/msg; print;' $f done And a couple of manual whitespace fixups. | |||
2014-11-28 | Revert "systemctl: append default suffix only if none present" | Zbigniew Jędrzejewski-Szmek | |
This reverts a chunk out of commit 5e03c6e3b517286bbd65b48d88f60e5b83721894 which was trying to pass NULL to the the '.service' default. Anyway, it seems better to be explicit. | |||
2014-11-28 | treewide: more log_*_errno + return simplifications | Michal Schmidt | |
2014-11-28 | systemctl: append default suffix only if none present | Zbigniew Jędrzejewski-Szmek | |
Simplify unit_name_mangle() and unit_name_mangle_with_suffix() to always behave the same, and only append a suffix if there is no type suffix. If a user says 'isolate blah.device' it is better to return an error that the type cannot be isolated, than to try to isolate blah.device.target. | |||
2014-11-28 | udevd: don't set receive buffer size when socket activated | Tom Gundersen | |
The socket unit does this, so no need to redo it in udevd. | |||
2014-11-28 | treewide: simplify log_*_errno(r,...) immediately followed by "return r" | Michal Schmidt | |
2014-11-28 | treewide: more log_*_errno() conversions, multiline calls | Michal Schmidt | |
Basically: find . -name '*.[ch]' | while read f; do perl -i.mmm -e \ 'local $/; local $_=<>; s/log_(debug|info|notice|warning|error|emergency)\("([^"]*)%s"([^;]*),\s*strerror\(-?([->a-zA-Z_]+)\)\);/log_\1_errno(\4, "\2%m"\3);/gms;print;' \ $f; done Plus manual indentation fixups. | |||
2014-11-28 | hostnamectl: Exit with zero on success | Martin Pitt | |
In show_all_names(), bus_map_all_properties() returns 1 on success which is then used as the return code of show_all_names() and eventually main(). Exit with zero in main() on all nonnegative results to guard against similar errors. | |||
2014-11-28 | udev,update-done: more log_xyz_errno() conversions | Lennart Poettering | |
2014-11-28 | sd-bus: make sure %m resolves to the specified error in bus_error_set_errnofv() | Lennart Poettering | |
2014-11-28 | bus-proxy: automatically detect scope of bus and derive which XML snippets ↵ | Lennart Poettering | |
to load from that | |||
2014-11-28 | sd-bus: rename default bus address constants, they aren't "paths" but ↵ | Lennart Poettering | |
"addresses" | |||
2014-11-28 | sd-bus: add new call sd_bus_get_scope() for querying whether one is ↵ | Lennart Poettering | |
connected to a system or a user bus | |||
2014-11-28 | sd-bus: rework credential query logic | Lennart Poettering | |
Also, make the call to free kdbus slices generic and use it everywhere | |||
2014-11-28 | treewide: more log_*_errno() conversions | Michal Schmidt | |
2014-11-28 | treewide: drop unnecessary trailing \n in log_*() calls | Michal Schmidt | |
2014-11-28 | core: two more log_unit_*_errno() conversions | Michal Schmidt | |
2014-11-28 | core: convert log_unit_*() to log_unit_*_errno() | Michal Schmidt | |
Using: find . -name '*.[ch]' | xargs sed -r -i -e \ 's/log_unit_(debug|info|notice|warning|error|emergency)\(([^"]+), "(.*)%s"(.*), strerror\(-([a-zA-Z_]+)\)\);/log_unit_\1_errno(\2, \5, "\3%m"\4);/' | |||
2014-11-28 | core: add log_unit_*_errno() macros | Michal Schmidt | |
2014-11-28 | treewide: no need to negate errno for log_*_errno() | Michal Schmidt | |
It corrrectly handles both positive and negative errno values. | |||
2014-11-28 | treewide: auto-convert the simple cases to log_*_errno() | Michal Schmidt | |
As a followup to 086891e5c1 "log: add an "error" parameter to all low-level logging calls and intrdouce log_error_errno() as log calls that take error numbers", use sed to convert the simple cases to use the new macros: find . -name '*.[ch]' | xargs sed -r -i -e \ 's/log_(debug|info|notice|warning|error|emergency)\("(.*)%s"(.*), strerror\(-([a-zA-Z_]+)\)\);/log_\1_errno(-\4, "\2%m"\3);/' Multi-line log_*() invocations are not covered. And we also should add log_unit_*_errno(). | |||
2014-11-28 | shared: fix log_emergency_errno macro | Michal Schmidt | |
It was not passing the error argument. | |||
2014-11-28 | kdbus: when running in a container, don't complain that we cannot write to /sys | Lennart Poettering | |
2014-11-28 | log: change log_xyz_errno() calls to always return the negative error | Lennart Poettering | |
This enables us to write things like this: int open_some_file(void) { fd = open("/dev/foobar", O_RDWR|O_CLOEXEC); if (fd < 0) return log_error_errno(errno, "Failed to reboot: %m"); return fd; } Which is function that returns -errno on failure, as well as printing an error message, all in one line. | |||
2014-11-28 | log: make socket address structs static const | Lennart Poettering | |
2014-11-28 | log: also set errno to the passed error code before processing format string ↵ | Lennart Poettering | |
in log_struct() That way the caller may use %m to print the specified error. | |||
2014-11-28 | core: only override kdbus attach mask when running as PID 1 | Lennart Poettering | |
2014-11-28 | sd-bus: the attach_mask kernel module parameter is 64bit now, hence ↵ | Lennart Poettering | |
initialize it as such | |||
2014-11-28 | log: allow negative errno values | Lennart Poettering | |
sd_bus_error_set_errno() allows negative errors too, hence, be equally nice. | |||
2014-11-28 | log: fix order of log_unit_struct() to match other logging calls | Lennart Poettering | |
Also, while we are at it, introduce some syntactic sugar for creating ERRNO= and MESSAGE= structured logging fields. | |||
2014-11-28 | networkd: update logging macros for parameter order, and errno, to match ↵ | Lennart Poettering | |
rest of the code | |||
2014-11-28 | networkd: remove duplicate macro definitions | Lennart Poettering | |
2014-11-27 | sysv-generator: advertise the man page | Zbigniew Jędrzejewski-Szmek | |
2014-11-27 | fix build with --enable-terminal | Thomas Hindoe Paaboel Andersen | |
Broke with 086891e5c119abb9854237fc32e736fe2d67234c | |||
2014-11-27 | kmod-setup: simplify kernel command line parsing | Lennart Poettering | |
2014-11-27 | kdbus: set kernel attach mask before creating the first bus | Lennart Poettering | |
2014-11-27 | selinux: log selinux log messages with LOG_AUTH facility | Lennart Poettering | |
2014-11-27 | log: rearrange log function naming | Lennart Poettering | |
- Rename log_meta() → log_internal(), to follow naming scheme of most other log functions that are usually invoked through macros, but never directly. - Rename log_info_object() to log_object_info(), simply because the object should be before any other parameters, to follow OO-style programming style. | |||
2014-11-27 | log: be a bit less wasteful when allocating buffers | Lennart Poettering | |
2014-11-27 | log: add an "error" parameter to all low-level logging calls and intrdouce ↵ | Lennart Poettering | |
log_error_errno() as log calls that take error numbers This change has two benefits: - The format string %m will now resolve to the specified error (or to errno if the specified error is 0. This allows getting rid of a ton of strerror() invocations, a function that is not thread-safe. - The specified error can be passed to the journal in the ERRNO= field. Now of course, we just need somebody to convert all cases of this: log_error("Something happened: %s", strerror(-r)); into thus: log_error_errno(-r, "Something happened: %m"); | |||
2014-11-27 | sd-bus: set creds info for "org.freedesktop.DBus.Local" generated messages, too | Lennart Poettering | |
2014-11-27 | sd-bus: when we get the list of well-known names back from kdbus we ↵ | Lennart Poettering | |
shouldn't confuse the empty list with unknown information | |||
2014-11-27 | sd-bus: deal with whitespace in matches | Lennart Poettering | |
2014-11-27 | sd-bus: unify logic how we patch the message source of driver messages | Lennart Poettering | |
2014-11-27 | sd-bus: fake valid well-known-names metadata for faked bus messages | Lennart Poettering | |
2014-11-27 | sd-bus: optimize how we generate the well-known-names lists in messages from ↵ | Lennart Poettering | |
kdbus | |||
2014-11-27 | sd-bus: be stricter with mismatches between dbus1 and kdbus message headers | Lennart Poettering | |