summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2013-12-31dhcp: fix creation of req_opts arrayZbigniew Jędrzejewski-Szmek
GREEDY_REALLOC needs to have two size variables: one for the allocated size, and a second one for the used size. Using the allocated size only lead to leaving some elements unitialized and assigning some more than once.
2013-12-31sleep-config: fix double freeZbigniew Jędrzejewski-Szmek
Before 34a3baa4d 'sleep-config: Dereference pointer before check for NULL' oom conditions would not be detected properly. After that commit, a double free was performed. Rework the whole function to be easier to understand, and also replace strv_split_nulstr with strv_new, since we know the strings anyway.
2013-12-31boot-efi: Remove superfluous assignmentStefan Beller
2 lines after the changed line we assign err to efi_get_variable(...) unconditionally, so it makes no sense to initialize it to some value.
2013-12-30sleep-config: Dereference pointer before check for NULLStefan Beller
This fixes a bug pointed out by http://css.csail.mit.edu/stack/ (Optimization-unstable code) It is a similar fix as f146f5e159 (2013-12-30, core: Forgot to dereference pointer when checking for NULL) To explain this bug consider the following similar, but simpler code: if (!p) free(*p) Assume the if condition evaluates to true, then we will access *p, which means the compiler can assume p is a valid pointer, so it could dereference p and use the value *p. Assuming p as a valid pointer, !p will be false. But initally we assumed the condition evaluates to true. By this reasoning the optimizing compiler can deduce, we have dead code. ("The if will never be taken, as *p must be valid, because otherwise accessing *p inside the if would segfault") This led to an error message of the static code checker, so I checked the code in question. As we access *modes and *states before the check in the changed line of this patch, I assume the line to be wrong and we actually wanted to check for *modes and *states being both non null.
2013-12-30bootchart: Remove unneeded check for NULLStefan Beller
Directly before the changed line there is: while ((parent->next_ps && parent->pid != ps->ppid)) parent = parent->next_ps; which looks one element ahead of the list, hence we can rely on parent being non null here. If 'parent' were NULL at that while loop already, it would crash as we're dereferencing 'parent' when checking for next_ps already. Signed-off-by: Stefan Beller <stefanbeller@googlemail.com>
2013-12-30tmpfiles: rename --unsafe to --bootZbigniew Jędrzejewski-Szmek
As suggested by Kay, it is better to describe what is done, not what might happen.
2013-12-30core: Forgot to dereference pointer when checking for NULLStefan Beller
Actually we already checked for !rt before, now we'd like to examine the return value of the memory allocation.
2013-12-30systemd-python: fix listen_fds under Python 2Zbigniew Jędrzejewski-Szmek
2013-12-30systemd-python: fix setting of exception codesZbigniew Jędrzejewski-Szmek
The return value of 0 would be treated as failure by mistake, resulting in " SystemError: error return without exception set". The way that set_error() is used is changed to be the same everywhere.
2013-12-30acticate: rename --environment to --setenvZbigniew Jędrzejewski-Szmek
Nspawn has --setenv, and systemd itself accepts systemd.setenv. It is nice to have the same parameter name everywhere. Old name is accepted, but not advertised.
2013-12-29udev: LOG_PRIORITY -> LOG_LEVELKay Sievers
2013-12-28bus: fix a couple of format string mistakesLennart Poettering
2013-12-28bus: driverd; add missing format string parameterMarc-Antoine Perennou
This was causing a nasty coredump
2013-12-28bus: correct a number of gcc format string attribute usagesLennart Poettering
2013-12-27selinux: Check access vector for enable/disable perm for each unit fileLubomir Rintel
SELinux check will be done using the context of the unit file as as a target instead of the default init_t context, allowing selinux control on the level of individual units. https://bugzilla.redhat.com/show_bug.cgi?id=1022762
2013-12-28shared: add simplistic XML parser for usage in the D-Bus policy language ↵Lennart Poettering
compat parser
2013-12-27bus: fix running tests in parallelZbigniew Jędrzejewski-Szmek
2013-12-27bus: PORTING-DBUS1: fix user bus pathMantas Mikulėnas
2013-12-27systemctl: remove unused variableThomas Hindoe Paaboel Andersen
2013-12-27bus: PORTING-DBUS1 typo fixesThomas Hindoe Paaboel Andersen
2013-12-27bus: PORTING-DBUS1 clarify pool size valueKay Sievers
2013-12-27bus: PORTING-DBUS1 updateKay Sievers
2013-12-27bus: update PORTING-DBUS1Kay Sievers
2013-12-27bus: actually, the kernel does enforce validity of bus names...Lennart Poettering
2013-12-27bus: explain obsoletion of dbus1 .service filesLennart Poettering
2013-12-27bus: refuse invalid names from kbus meta dataLennart Poettering
2013-12-27bus: add some preliminary docs for porting existing dbus1 client libraries ↵Lennart Poettering
to kdbus
2013-12-26bus: update kdbus.hKay Sievers
2013-12-26Use enums to make it obvious what boolean params meanZbigniew Jędrzejewski-Szmek
Suggested-by: Russ Allbery <rra@debian.org>
2013-12-26systemctl: allow globbing in commands which take multiple unit namesZbigniew Jędrzejewski-Szmek
2013-12-26systemctl: drop uninteresting units immediatelyZbigniew Jędrzejewski-Szmek
Also properly free memory if list-unit-files --root=... is used.
2013-12-26systemctl: simplify start_unitZbigniew Jędrzejewski-Szmek
2013-12-26bus: add a temporary hard-coded policy to proxyd to make gdm workLennart Poettering
gdm relies on the policy to deny its own requests to not deadlock. Given that we currently do not enforce any policy in the dbus1 compat proxy service this means that gdm will necessarily deadlock on our systems. To work around this, enforce a fixed policy teomporarily, until we interpret the legacy XML policy in full. Booh, gdm, booh, for requring this and making me waste two days on tracking this brokenness down.
2013-12-26bus: always show messages we sendLennart Poettering
2013-12-26bus: don't process Peer interface messages in the proxyLennart Poettering
2013-12-26bus: make system bus kdbus node world-accessibleLennart Poettering
2013-12-26journalctl: make sure -b --foobar cannot be misunderstood as --boot=--foobarLennart Poettering
2013-12-26Revert "journalctl: remove unexpected behavior of journalctl -b"Lennart Poettering
This reverts commit cf5bccc2bb9569030cb04debbc4208aaca0fe5b4. We should fix thinks properly if they aren't perfect, not just break other things...
2013-12-25build-sys: minor fixes found with cppcheckLennart Poettering
2013-12-25journalctl: remove unexpected behavior of journalctl -bDave Reisner
This flag shouldn't try and consume the following argument. It should behave like every other flag which takes an optional argument when parsed by getopt_long.
2013-12-25bus: add a bit of pure/const decoratorsLennart Poettering
2013-12-25man: document sd_bus_message_get_cookie()Lennart Poettering
2013-12-25bus: rename message "serial" to "cookie"Lennart Poettering
Even if the lower-leveld dbus1 protocol calls it "serial", let's expose the word "cookie" for this instead, as this is what kdbus uses and since it doesn't imply monotonicity the same way "serial" does.
2013-12-25bus: conditionally set cookie_reply/timeout and update kdbus.hKay Sievers
2013-12-25bus: update kdbus.hKay Sievers
2013-12-25bus: set cookie_reply and update kdbus.hKay Sievers
2013-12-25bus: also write debug logs about messages we sendLennart Poettering
2013-12-25bus: be a bit more verbose when debug mode is onLennart Poettering
2013-12-25shared: fix getpeername_pretty() for AF_UNIX socketsLennart Poettering
2013-12-25unit: include peer identity in description of per-connection ↵Lennart Poettering
socket-activated services