summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2012-04-23transaction: cancel jobs non-recursively on isolateMichal Schmidt
Recursive cancellation of jobs would trigger OnFailure actions of dependent jobs. This is not desirable when isolating. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=798328
2012-04-24job: serialize jobs properlyMichal Schmidt
Jobs were not preserved correctly over a daemon-reload operation. A systemctl process waiting for a job completion received a job removal signal. The job itself changed its id. The job timeout started ticking all over again. This fixes the deficiencies.
2012-04-24transaction: abort does not need to use recursive deletionMichal Schmidt
Recursion is unnecessary, because we're deleting all transaction jobs anyway. And the recursive deletion produces debug messages that are pointless in transaction abort.
2012-04-24transaction: fix detection of cycles involving installed jobsMichal Schmidt
A transaction can be acyclic, but when it's added to installed jobs, a cycle may result. transaction_verify_order_one() attempts to detect these cases, but it fails because the installed jobs often have the exact generation number that makes them look as if they were walked already. Fix it by resetting the generation numbers of all installed jobs before detecting cycles. An alternative fix could be to add the generation counter to the Manager and use it instead of starting always from 1 in transaction_activate(). But I prefer not having to worry about it wrapping around.
2012-04-24transaction: improve readabilityMichal Schmidt
The functions looked complicated with the nested loops with breaks, continues, and "while (again)". Here using goto actually makes them easier to understand. Also correcting the comment about redundant jobs.
2012-04-22shutdown: don't try to shut down DM devices in a containerLennart Poettering
2012-04-22hostname: if there's already a hostname set when PID 1 is invoked, don't ↵Lennart Poettering
complain
2012-04-22job: the status messages are proper sentences, hence end them with a full stopLennart Poettering
2012-04-22mount: don't fail if fstab doesn't existLennart Poettering
2012-04-22transaction: downgrade warnings about masked unitsLennart Poettering
2012-04-22transaction: add missing emacs and license headersLennart Poettering
2012-04-22machine-id: fix spellingLennart Poettering
2012-04-22util: unify getenv() logic for other PIDLennart Poettering
2012-04-22nspawn: add --uuid= switch to allow setting the machine id for the containerLennart Poettering
2012-04-22nspawn: add -b switch to automatically look for an init binaryLennart Poettering
2012-04-22default to v102 everywhere, instead of vt100, to synchronize with agettyLennart Poettering
2012-04-22login: assing /dev/console logins to seat0Lennart Poettering
2012-04-22container: spawn a getty instead of a sulogin in a containerLennart Poettering
2012-04-22loginctl: avoid segfault for kill-session and kill-user commandsLennart Poettering
As reported by Mantas Mikulėnas. http://lists.freedesktop.org/archives/systemd-devel/2012-April/004993.html
2012-04-22util: fix tty_is_vc_resolve() in a container where ↵Lennart Poettering
/sys/class/tty/console/active is misleading
2012-04-22log: include syslog identifier in default log properties, to avoid comm ↵Lennart Poettering
truncation
2012-04-22nspawn: be more careful when initializing the hostname from the directory nameLennart Poettering
2012-04-22mount-setup: ignore common container bind mountsLennart Poettering
2012-04-22nspawn: make /dev/kmsg unavailable in the container, but allow access to ↵Lennart Poettering
/proc/kmsg
2012-04-21watchdog: fix default configuration fragment for watchdogLennart Poettering
2012-04-20transaction: add starting requirements for JOB_RESTARTMichal Schmidt
While having a Requires= dependency between units, the dependency is started automatically on "systemctl start", but it's not started on "systemctl restart". JOB_RESTART jobs did not pull the dependencies for starting into the transaction. https://bugzilla.redhat.com/show_bug.cgi?id=802770 Note that the other bug noted in comment #2 has been fixed already by avoiding the deletion of anchor jobs.
2012-04-20dbus-job: allow multiple bus clientsMichal Schmidt
Merging of jobs can result in more than one client being interested in a job.
2012-04-20transaction: remove checks for installedMichal Schmidt
Transactions cannot contain installed jobs anymore. Remove the now pointless checks.
2012-04-20transaction: rework merging with installed jobsMichal Schmidt
Previously transactions could reference installed jobs. It made some issues difficult to fix. This sets new rules for jobs: A job cannot be both a member of a transaction and installed. When jobs are created, they are linked to a transaction. The whole transaction is constructed (with merging of jobs within, etc.). When it's complete, all the jobs are unlinked from it one by one and let to install themselves. It is during the installation when merging with previously installed jobs (from older transactions) is contemplated. Merging with installed jobs has different rules than merging within a transaction: - An installed conflicting job gets cancelled. It cannot be simply deleted, because someone might be waiting for its completion on DBus. - An installed, but still waiting, job can be safely merged into. - An installed and running job can be tricky. For some job types it is safe to just merge. For the other types we merge anyway, but put the job back into JOB_WAITING to allow it to run again. This may be suboptimal, but it is not currently possible to have more than one installed job for a unit. Note this also fixes a bug where the anchor job could be deleted during merging within the transaction.
2012-04-20job: separate job_install()Michal Schmidt
Let the jobs install themselves.
2012-04-20transaction: remove a couple of assertsMichal Schmidt
We already asserted these facts in the previous loop.
2012-04-20transaction: remove the anchor linkMichal Schmidt
tr->anchor_job is sufficient.
2012-04-20transaction: avoid garbage collecting the anchor jobMichal Schmidt
Make sure the anchor job is never considered garbage, even if it has no links leading to it (this will be allowed in the next patch).
2012-04-20transaction: simplify transaction_find_jobs_that_matter_to_anchor()Michal Schmidt
2012-04-20transaction: change the linking of isolate jobs to the anchorMichal Schmidt
When isolating, the JOB_STOP jobs have no parent job, so they are all peers of the real anchor job. This is a bit odd. Link them from the anchor job.
2012-04-20transaction: maintain anchor_jobMichal Schmidt
Track which job is the anchor in the transaction.
2012-04-20transaction: do not add installed jobs to the transactionMichal Schmidt
Do not attempt to optimize away the job creation by refering to installed jobs. We do not want to disturb installed jobs until commiting the transaction. (A later patch to job merging will make the separation of transaction jobs and installed jobs complete.)
2012-04-20job: jobs shouldn't need to know about transaction anchorsMichal Schmidt
Let the transactions maintain their own anchor links.
2012-04-20job: job_new() can find the manager from the unitMichal Schmidt
2012-04-20manager: split transaction.[ch]Michal Schmidt
manager.c takes care of the main loop, unit management, signal handling, ... transaction.c computes transactions. After split: manager.c: 65 KB transaction.c: 40 KB
2012-04-20manager: Transaction as an objectMichal Schmidt
This makes it obvious that transactions are short-lived. They are created in manager_add_job() and destroyed after the application of jobs. It also prepares for a split of the transaction code to a new source.
2012-04-20job: job_uninstall()Michal Schmidt
Split the uninstallation of the job from job_free() into a separate function. Adjust the callers. job_free() now only works on unlinked and uninstalled jobs. This enforces clear thinking about job lifetimes.
2012-04-20manager: simplify transaction_abort()Michal Schmidt
This is equivalent.
2012-04-20job: allow job_free() only on already unlinked jobsMichal Schmidt
job_free() is IMO too helpful when it unlinks the job from the transaction. The callers should ensure the job is already unlinked before freeing. The added assertions check if anyone gets it wrong.
2012-04-20manager: fix commentMichal Schmidt
2012-04-20tmpfiles: fix error messageMichal Schmidt
2012-04-20log: fix LOG_TARGET_JOURNAL_OR_KMSGLennart Poettering
2012-04-20mount-setup: don't log with LOG_ERROR if a mount that doesn't matter failsLennart Poettering
2012-04-20main: log to the journal in container mode, by defaultLennart Poettering
2012-04-20docs: hook-up gtk-doc to 'make check'Kay Sievers