summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2016-03-04test-selinux: use yes_no() and strnull()Zbigniew Jędrzejewski-Szmek
2016-03-04networkctl: avoid reading past end of input bufferZbigniew Jędrzejewski-Szmek
name is IFNAMSIZ bytes, but we would copy sizeof(info->name) bytes, which is IFNAMSIZ + 1. In effect we would go outside of the source buffer and possibly leave a non-null terminated string in info->name. CID #1351754.
2016-03-04networkctl: use ETHER_ADDR_NULL in one more placeZbigniew Jędrzejewski-Szmek
2016-03-04lldp: fix memleakZbigniew Jędrzejewski-Szmek
in_addr_to_string returned 0, which was treated as error by the calling code, which expects 1 on success. CID #1351757, #1351758.
2016-03-04test-libudev: disable monitor mode by default and add to automatic testsZbigniew Jędrzejewski-Szmek
2016-03-04test-libudev: modernizationZbigniew Jędrzejewski-Szmek
2016-03-04Enable test-ipcrm, test-hostname in unsafe testsZbigniew Jędrzejewski-Szmek
2016-03-04Enable test-daemon, test-log, test-watchdog by defaultZbigniew Jędrzejewski-Szmek
Those should be safe to run, resulting in some messages in logs.
2016-03-04shared/acpi-fpdt: use ENODATA for missing data and skip testZbigniew Jędrzejewski-Szmek
This data is simply missing on non-UEFI systems, and it is useful to distinguish that from corrupted data.
2016-03-04Rename test-boot-timestamp to test-boot-timestamps and enable by defaultZbigniew Jędrzejewski-Szmek
The source file name and the binary name were mismatched. Rename binary to match. Make the test exit with TEST_SKIP if the data is missing or we have no permissions. Otherwise, the data will be printed, which should be safe to enable by default.
2016-03-04Move test-loopback to normal testsZbigniew Jędrzejewski-Szmek
In the normal case lo should be already configured and this should be a noop, even when run under root.
2016-03-03Merge pull request #2781 from keszybz/selinux-and-warningsLennart Poettering
Selinux loading fix and warning cleanups
2016-03-02systemctl: rm empty dropin dirs after cancelled editRonny Chevalier
Fixes #2734
2016-03-02Redefine 32bit time_t format to signedZbigniew Jędrzejewski-Szmek
It seems that it is signed both on i386 and arm. Avoids a stupid gcc warning on arm: src/udev/udevadm-monitor.c: In function ‘print_device’: src/udev/udevadm-monitor.c:44:16: warning: format ‘%u’ expects argument of type ‘unsigned int’, but argument 3 has type ‘__time_t {aka long int}’ [-Wformat=] printf("%-6s[%"PRI_TIME".%06ld] %-8s %s (%s)\n", ^
2016-03-02test-sizeof: add a helper which prints variable sizes and signednessZbigniew Jędrzejewski-Szmek
This helps to understand misleading gcc warnings about type mismatches.
2016-03-02test-selinux: add some simple tests which call functions and print the ↵Zbigniew Jędrzejewski-Szmek
results and timings
2016-03-02selinux: use raw variants of security_compute_create and setfscreateconZbigniew Jędrzejewski-Szmek
As suggested by Evgeny Vereshchagin as a follow up for https://github.com/systemd/systemd/pull/2781#issuecomment-191043402.
2016-03-02Merge pull request #2779 from 0xAX/openat-opath-excess-flagsDaniel Mack
tree-wide: no need to pass excess flags to open()/openat() if O_PATH …
2016-03-01selinux: always try to load the full selinux dbZbigniew Jędrzejewski-Szmek
https://github.com/systemd/systemd/pull/2508#issuecomment-190901170 Maybe fixes https://bugzilla.redhat.com/show_bug.cgi?id=1308771.
2016-03-02tree-wide: no need to pass excess flags to open()/openat() if O_PATH is passedAlexander Kuleshov
As described in the documentation: When O_PATH is specified in flags, flag bits other than O_CLOEXEC, O_DIRECTORY, and O_NOFOLLOW are ignored. So, we can remove unnecessary flags in a case when O_PATH is passed to the open() or openat().
2016-03-01ask-password: add option --no-output to not print password to stdoutChristian Hesse
systemd-ask-password can store passwords in kernel keyring. However it uses to print the passwords to standard output nevertheless. Depending on where systemd-ask-password is called passwords may end on display or in log, leaking sensitive information. This allows to make systemd-ask-password quiet, effectively disabling printing passwords to standard output.
2016-03-01Merge pull request #2773 from eliasp/type-warningsDaniel Mack
Use `PRIu64` to print `uint64_t` in log msgs
2016-02-29Merge pull request #2702 from poettering/resolved-iterate-fixZbigniew Jędrzejewski-Szmek
resolved iteration fix
2016-02-29Merge pull request #2767 from benjarobin/fix-warnZbigniew Jędrzejewski-Szmek
systemctl: Fix warn: action_to_runlevel() is not used
2016-02-29Use `PRIu64` to print `uint64_t` in log msgsElias Probst
2016-02-29Merge pull request #2771 from 0xAX/core-kernel-timestamp-cleanupLennart Poettering
core: use DUAL_TIMESTAMP_NULL to reset kernel_timestamp
2016-02-29Merge pull request #2769 from martinpitt/adjtimeLennart Poettering
Fixes for adjtime parsing
2016-02-29test-clock: fix FILE* leakMartin Pitt
Close the FILE* instead of the underlying fd.
2016-02-29Merge pull request #2763 from tblume/shorten-hostname-before-removing-dotsLennart Poettering
shorten hostname before checking for trailing dot
2016-02-29Merge pull request #2756 from thom311/masterLennart Poettering
core: avoid compiler warning when compiling with -fexceptions
2016-02-29test-clock: fix assertionsMartin Pitt
Use assert_se() to ensure that they don't get optimized away.
2016-02-29timedated: trivial stylistic fixMartin Pitt
Don't use {} for single-line "then" blocks.
2016-02-29systemctl: Fix warn: action_to_runlevel() is not usedBenjamin ROBIN
If HAVE_SYSV_COMPAT is not defined: ‘action_to_runlevel’ defined but not used
2016-02-29test-clock: fix fd "leak"Zbigniew Jędrzejewski-Szmek
CID #1352301.
2016-02-29core: use DUAL_TIMESTAMP_NULL to reset kernel_timestampAlexander Kuleshov
instead of direct reset of kernel_timestamp fields.
2016-02-29stdio-bridge: Correctly propagate errorBenjamin Robin
Return EXIT_FAILURE and print the correct errno code if sd_bus_get_fd() or sd_bus_get_events() fail
2016-02-29shorten hostname before checking for trailing dotThomas Blume
Shortening can lead to a hostname that has a trailing dot. Therefore it should be done before checking from trailing dots.
2016-02-28Merge pull request #2753 from phomes/trivial-fixes2Zbigniew Jędrzejewski-Szmek
Trivial fixes
2016-02-28Merge pull request #2749 from martinpitt/adjtimeZbigniew Jędrzejewski-Szmek
2016-02-27core: avoid compiler warning when compiling with -fexceptionsThomas Haller
Initialize auto variables with cleanup attribute, otherwise we get a compiler warning with -fexceptions. ./configure CFLAGS='-Wmaybe-uninitialized -fexceptions -O2'
2016-02-26stdio-bridge: remove dead codeThomas Hindoe Paaboel Andersen
2016-02-26tree-wide: indentation fixesThomas Hindoe Paaboel Andersen
2016-02-26timedated: be more tolerant in parsing /etc/adjtimeMartin Pitt
Similarly to the previous commit, make context_write_data_local_rtc() understand /etc/adjtime files with just one or two lines, with or without a final newline. Normalize the file to the current definition in hwclock(8), in the spirit of "be liberal what you accept and strict what you produce": Add line terminators, and set the second line to "0" if missing. Fixes: #2638
2016-02-26clock-util: be more tolerant in parsing /etc/adjtimeMartin Pitt
As we default to "hardware clock is in UTC" if /etc/adjtime is not present, it also makes sense to have that default if /etc/adjtime contains only one or two lines. Drop the "gibberish" test case, as this was just EIO because of not containing three lines, which is already contained in other tests. clock_is_localtime() never actually validated the format of the first two lines, and there is little point in doing that. This addresses the reading half of issue #2638.
2016-02-26clock-util: make clock_is_localtime() testable and add initial testsMartin Pitt
Add path argument to clock_is_localtime() and default to "/etc/adjtime" if it's NULL. This makes the function testable. Add test-clock: initial test cases for some scenarios, using a temporary file. This also checks the behaviour with a NULL (i. e. the system's /etc/adjtime) file.
2016-02-25Merge pull request #2671 from 0xAX/move-pager-open-to-one-placeZbigniew Jędrzejewski-Szmek
tree-wide: merge pager_open_if_enabled() to the pager_open()
2016-02-26tree-wide: merge pager_open_if_enabled() to the pager_open()Alexander Kuleshov
Many subsystems define own pager_open_if_enabled() function which checks '--no-pager' command line argument and open pager depends on its value. All implementations of pager_open_if_enabled() are the same. Let's merger this function with pager_open() from the shared/pager.c and remove pager_open_if_enabled() from all subsytems to prevent code duplication.
2016-02-25sd-dhcp-server: Send replies to BOOTP relay server portPatrik Flykt
RFC 2131 Section 4.1 says that "If the ’giaddr’ field in a DHCP message from a client is non-zero, the server sends any return messages to the ’DHCP server’ port on the BOOTP relay agent whose address appears in ’giaddr’." Fix this by adding a destination port when sending unicast UDP packets and provide the server port when a BOOTP relay agent is being used.
2016-02-24treewide: fix typos and then/that useTorstein Husebø
2016-02-24Merge pull request #2719 from evverx/add-test-to-makefileMartin Pitt
tests: various fixes