summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2015-03-09journalctl: unlink without checking with access firstZbigniew Jędrzejewski-Szmek
It is more elegant to do this in one step. Coverity complains about the TOCTOU difference, but it is not an actual problem (CID #1237777).
2015-03-09journal: fix return codeZbigniew Jędrzejewski-Szmek
Introduced in fa6ac76083b8ff. Might be related to CID #1261724, but I don't know if coverity can recurse this deep.
2015-03-09journal-file: update format string to remove castZbigniew Jędrzejewski-Szmek
2015-03-09journal: align comments to make them more legibleZbigniew Jędrzejewski-Szmek
2015-03-09libudev: add missing hunksTom Gundersen
This should have been committed with udev_device_add_property - implicitly mark properties for saving to db
2015-03-09libudev: udev_device_read_db - drop unused argumentTom Gundersen
2015-03-09libudev: udev_device_add_property - implicitly mark properties for saving to dbTom Gundersen
Properties should only be saved to the db when added to the udev_device by udevd, and only if the property does not start with a '.'. Make this implicit rather than expose the marking of properties.
2015-03-09udev/libudev: event - move {OLD_,}INTERFACE handling from udevd to libudevTom Gundersen
This should be internal to the library as it is only about reflecting the sysfs state in the udev_device.
2015-03-09libudev: private - make property_from_string_parse* staticTom Gundersen
2015-03-09udev: simplify event_queue_update() and add debug loggingTom Gundersen
This essentially replaces open("/run/udev/queue", O_WRONLY|O_CREAT|O_CLOEXEC|O_TRUNC|O_NOFOLLOW, 0444) with open("/run/udev/queue", O_WRONLY|O_CREAT|O_CLOEXEC|O_NOCTTY, 0644), which is ok for our purposes.
2015-03-09efivars: use greedy_reallocZbigniew Jędrzejewski-Szmek
2015-03-09efivars: use more _cleanup_Zbigniew Jędrzejewski-Szmek
Also rename r to buf, since r is customarily reserved for the return value.
2015-03-09efivars: do binary and before converting to boolZbigniew Jędrzejewski-Szmek
I'm pretty sure that this is what was meant here.
2015-03-09efivars: rename last remaining err to rZbigniew Jędrzejewski-Szmek
2015-03-09efivars: modernizationZbigniew Jędrzejewski-Szmek
Fix return value if unlink fails.
2015-03-09boot/efi: do not assign variable twiceZbigniew Jędrzejewski-Szmek
If the highlighted line did not move outside of the visible region, it should not be necessary to update idx_last. CID #1287137, #1287138.
2015-03-09machinectl: remove unused variablesThomas Hindoe Paaboel Andersen
2015-03-09fsck: modernize error handlingLennart Poettering
2015-03-09fsck: use _cleanup_close_pair_ where appropriateLennart Poettering
2015-03-09fsckd: make sure we free the connection event source before we close the ↵Lennart Poettering
connection fd
2015-03-09fsckd: don't allow unbounded numbers of clientsLennart Poettering
2015-03-09fsckd: free client event source before we close its fdLennart Poettering
2015-03-09fsck: rename functions to reflect some object orientationLennart Poettering
Let's clean up the function naming scheme and put the object they operate on first in the name, the way OO programming usually does it. Also, let's make sure can properly destroy half-initialized Manager objects.
2015-03-09fsck: don't read invalid dataLennart Poettering
2015-03-09fsckd: internaly check if a client already was cancelledLennart Poettering
2015-03-09fsck: simplify client destruction logicLennart Poettering
2015-03-09fsckd: rework plymouth connection managementLennart Poettering
- the even source should not be freed before the fd for it is closed - read() returns an ssize_t and we need to handle it as such - properly handle errors from read() - reuse on_plymouth_disconnect() whenever we disconnect from plymouth, and rename it plymouth_disconnect hence()
2015-03-09fscd: fix error handlingLennart Poettering
2015-03-09fsck: no need for a temporary variableLennart Poettering
2015-03-09fsckd: fix error handling when sending cancel request to fsck clientLennart Poettering
2015-03-09fsck: unify exit path for connect_plymouth()Lennart Poettering
2015-03-09fsck: use only a single exit code ternary operatorLennart Poettering
2015-03-09fsck: simplificationLennart Poettering
2015-03-09fsckd: the error code is actually returned in 'fd'Lennart Poettering
Also, we don't use {} for single-line if-blocks.
2015-03-09fsckd: simplify code a bitLennart Poettering
2015-03-09fsckd: make use of safe_close()'s return valueLennart Poettering
2015-03-09build-sys: add one more Makefile symlinkLennart Poettering
2015-03-09importd: add API for exporting container/VM imagesLennart Poettering
Also, expose it in machinectl.
2015-03-09udev: use inttypes.h types wherever appropriateLennart Poettering
2015-03-09tree-wide: use _packed_ macro instead of raw gcc __attribute__Lennart Poettering
2015-03-09udevd: close race in udev settleTom Gundersen
The udev-settle guarantees that udevd is no longer processing any of the events casued by udev-trigger. The way this works is that it sends a synchronous PING to udevd after udev-trigger has ran, and when that returns it knows that udevd has started processing the events from udev-trigger. udev-settle will then wait for the event queue to empty before returning. However, there was a race here, as we would only update the /run state at the beginning of the event loop, before reading out new events and before processing the ping. That means that if the first uevent arrived in the same event-loop iteration as the PING, we would return the ping before updating the queue state in /run (which would happen on the next iteration). The race window here is tiny (as the /run state would probably get updated before udev-settle got a chance to read /run), but still a possibility. Fix the problem by updating the /run state as the last step before returning the PING. We must still update it at the beginning of the loop as well, otherwise we risk being stuck in poll() with a stale state in /run. Reported-by: Daniel Drake <drake@endlessm.com>
2015-03-09missing.h: add NDA_*Michael Olbrich
This is necessary to build with older kernel headers. NDA_VLAN was introduced in v3.9 and NDA_PORT, NDA_VNI and NDA_IFINDEX in v3.10
2015-03-09Fix typosTorstein Husebø
2015-03-08sd-journal: return error when we cannot open a fileZbigniew Jędrzejewski-Szmek
Lack of this caused journalctl not to display a hint about missing groups properly when the user lacks permissions.
2015-03-08journalctl: update hint now that we set ACL everywhereZbigniew Jędrzejewski-Szmek
2015-03-07bus: fix leak in error pathZbigniew Jędrzejewski-Szmek
CID #1271349.
2015-03-07systemctl: remove dead checkZbigniew Jędrzejewski-Szmek
r could never be less than zero. CID #1271350.
2015-03-07core/load-fragment: safe_close() protects errnoZbigniew Jędrzejewski-Szmek
2015-03-07libsystemd-terminal: use at most LOG_ERR for XKB errorsZbigniew Jędrzejewski-Szmek
XKB errors aren't *that* important. Coverity complained that the same action is taken in multiple branches, which is semi-valid, so is fixed too (CID #1256582).
2015-03-07login: fix copy-pasto in error pathZbigniew Jędrzejewski-Szmek
CID #1256583.