summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2011-12-14pam-module: add a couple of debugging printsMichal Schmidt
2011-12-09unit: check for unneeded dependencies even when unit stop was expectedMichal Schmidt
systemd did not stop units marked as "StopWhenUnneeded=yes" when the requiring unit was stopped on user's request. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=704197
2011-12-09unit: fix false positive in check for unneeded unitMichal Schmidt
A freshly started unit A was immediately considered unneeded just because unit B, which Requires A, was starting later in the transaction. Fix it by looking not only at the state of B, but also at its pending job. Also fix a copied&pasted comment.
2011-12-08path: add missing pieces for PathModifiedMichal Schmidt
PATH_MODIFIED worked internally for PID files detection, but was unusable in units.
2011-12-06systemctl: print 'error' load state in redMichal Schmidt
Be consistent in coloring of load states in list-units and status. Print only 'error' in red. There are no 'banned' or 'failed' states. Do not color 'masked', it's not an error.
2011-12-06unit: garbage collect units with load errorMichal Schmidt
Units that failed to load were never cleaned up. It was possible to reach the 128K limit of units by attempting to load a bunch of nonsense. Bug observed by Reartes Guillermo in https://bugzilla.redhat.com/show_bug.cgi?id=680122
2011-12-05Allow 'list-unit-files' to run with --root.Bill Nottingham
To do so, move the check for the bus to the bus-using portion of list_unit_files(), and ensure that get_config_path doesn't abort when checking the runtime path with --root.
2011-12-03service: stop the service if ExecStartPost ends with a failureMichal Schmidt
The handling of failures in ExecStartPost is inconsistent. If the command times out, the service is stopped. But if the command exits with a failure, the service keeps running. It makes more sense to stop the service when ExecStartPost fails. If this behaviour is not desired, the ExecStartPost command can be prefixed with "-".
2011-12-03service: handle services with racy daemonization gracefullyMichal Schmidt
There are a lot of forking daemons that do not exactly follow the initialization steps as described in daemon(7). It is common that they do not bother waiting in the parent process for the child to write the PID file before exiting. The daemons' developers often do not perceive this as a bug and they're unwilling to change. Currently systemd warns about the missing PID file and falls back to guessing the main PID. Being not quite deterministic, the guess can be wrong with bad consequences. If the guessing is disabled, determinism is achieved at the cost of losing the ability of noticing when the main process of the service dies. As long as it does not negatively affect properly written services, systemd should strive for compatibility even with services with racy daemonization. It is possible to provide determinism _and_ main process supervision to them. If the PID file is not there, rather than guessing and considering the service running immediately after getting the SIGCHLD from the ExecStart (or ExecStartPost) process, we can keep the service in the activating state for a bit longer. We can use inotify to wait for the PID file to appear. Only when it finally does appear and we read a valid PID from it, we'll move the service to the running state. If the PID file never appears, the usual timeout kicks in and the service fails.
2011-12-03path: add PathModified (= PathChanged + IN_MODIFY)Michal Schmidt
2011-12-03path: refactor PathSpec usageMichal Schmidt
path_*() functions operate on "Path *p" and they do not touch PathSpec internals directly. pathspec_*() functions operate on "PathSpec *s". The PathSpec class will be useful outside of path.c.
2011-12-03path: use %m instead of strerror(errno)Michal Schmidt
and strerror(-errno) was just wrong.
2011-12-03util: fix error checking after fgets()Michal Schmidt
fgets() does not set errno on EOF.
2011-12-02add a generator to pull rc-local.service inMichal Schmidt
rc-local.service acts as an ordering barrier even if its condition is false, because conditions are evaluated when the service is about to be started. To avoid the ordering barrier in a legacy-free system, add a generator to pull rc-local.service into the transaction only if the script is executable. If/when we rewrite SysV compatibility into a generator, this one can become a part of it.
2011-11-30syslog: use PassCred=yes for the /dev/log socketMichal Schmidt
Both kmsg-syslogd and the real syslog service want to receive SCM_CREDENTIALS. With socket activation it is too late to set SO_PASSCRED in the services.
2011-11-30shutdownd: use PassCred=yes in the socket unitMichal Schmidt
Since Linux 3.2 in order to receive SCM_CREDENTIALS it is not sufficient to set SO_PASSCRED just before recvmsg(). The option has to be already set when the sender sends the message. With socket activation it is too late to set the option in the service. It must be set on the socket right from the start. See the kernel commit: 16e57262 af_unix: dont send SCM_CREDENTIALS by default Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=757628
2011-11-30socket: add option for SO_PASSCREDMichal Schmidt
Add an option to enable SO_PASSCRED for unix sockets.
2011-11-19let mount and swap units log to the configured defaultsMichal Schmidt
Related-to: https://bugzilla.redhat.com/show_bug.cgi?id=750032
2011-11-19pam-module: treat "cron" in PAM_TTY as empty ttyMichal Schmidt
cron sets PAM_TTY to "cron" and it has been doing it for a long time. It cannot be changed because user configurations may depend on it. https://bugzilla.redhat.com/show_bug.cgi?id=727315
2011-11-19pam-module: use the correct session type "unspecified"Michal Schmidt
logind does not understand "other".
2011-11-17execute: log errors from "sd(EXEC)"Michal Schmidt
To give the administrator more hints about failures occuring in spawning of commands than just the exit code, log the strerror. All fds are closed, so reopen the log. Related-to: https://bugzilla.redhat.com/show_bug.cgi?id=752901
2011-11-17execute: make setup_pam() return -errno when possibleMichal Schmidt
The only caller currently checks if the result is non-zero, so nothing changes there.
2011-11-16execute: avoid logging to closed fdsMichal Schmidt
Several functions called from the "sd(EXEC)" process try to log messages when all the file descriptors are already closed, including the logging ones. The logging functions do not expect their fds to be closed and they hit an assertion failure. The failure wants to be logged too, so there is an infinite recursion, ended by a SIGSEGV. When we close all fds, we must let log.c know about it.
2011-11-14Fix same expression on both sides of '&&'Thomas Jarosch
The code should probably look like the statements above it. Please verify, I just detected it using cppcheck. Signed-off-by: Thomas Jarosch <thomas.jarosch@intra2net.com>
2011-11-11job: colored status messages on bootMichal Schmidt
The lack or green/red status marks on boot has been described by some users as "critical", "dramatic", "dealbreaker", "showstopper". Seriously.
2011-11-10service: don't warn if the pidfile still exists after SIGCHLDMichal Schmidt
A service that drops its privileges may not be able to remove it when it exits. The stale pidfile is not a problem as long as the service carefully recognizes it on its next start. systemd would produce a warning after the service exits: PID ... read from file ... does not exist. Your service or init script might be broken. Silence the warning in this case. Still warn if this error is detected when loading the pidfile after service start. Noticed by Miroslav Lichvar in https://bugzilla.redhat.com/show_bug.cgi?id=752396
2011-11-07utmp: for DEAD_PROCESS write the current time to wtmpMichal Schmidt
Zeroed .ut_tv values in wtmp confuse chkrootkit. Reported and debugged by Norman Smith. This is based on his patch, but modified to behave more like upstart did in F14 and cleaned up. https://bugzilla.redhat.com/show_bug.cgi?id=743696
2011-11-07utmp: initialize store with the found entry, not with the lookup keyMichal Schmidt
2011-11-07utmp: no need to zero a struct before overwriting it with memcpyMichal Schmidt
2011-11-07utmp: remove unneded parametersMichal Schmidt
With these functions no caller ever passes anything else than 0 for 't' (meaning the current time will be used).
2011-11-03cgroup: immediately remove all cgroups which run emptyLennart Poettering
Some controllers have scaling problems when many empty cgroups exist. Hence, as soon as we get a notification that a cgroup is empty, delete it. This is also nice to keep the systemd-cgls output short.
2011-11-02Merge remote-tracking branch 'zbigniew/systemadm_changes'Lennart Poettering
2011-11-02bash-completion: rename file since it is no longer for systemctl onlyRan Benita
2011-11-02bash-completion: add completions for systemd-loginctlRan Benita
This script is straightforward and should give proper completions for all of systemd-loginctl's verbs.
2011-11-02bash-completion: update with new verbs and argumentsRan Benita
Adds arguments --root= --runtime --no-legend. Adds verbs link mask unmask reenable list-unit-files. Also uses list-unit-files to make nicer enable and disable completions. Rebased due to changes in systemctl.
2011-11-02Add Mageia supportDexter Morgan
This patch adds support for the Mageia Linux distribution: http://www.mageia.org/ Mageia is a fork of Mandriva although some divergence has already occured and thus inclusion of these changes upstream allow us to (hopefully) migrate more rapidly to the new standard approaches systemd offers. Indeed, we already use the preferred mechanism of OS identification via the /etc/os-release file rather than a distro specific variation. This patch mostly mirrors the patch added previously for Mandriva support. In addition to those original authors, this patch was mostly written by Dexter Morgan with help from Colin Guthrie and Eugeni Dodonov.
2011-11-01cryptsetup-generator: avoid ordering cycle on swapTom Gundersen
Devices with random keys (swap), should not be ordered before local-fs.target, as this creates a cycle with systemd-load-random-seed.service (and also it does not make sense, a swap device is not a local-fs).
2011-11-01mount: order remote mounts after both network.target and remote-fs-pre.targetLennart Poettering
Since remote-fs-pre.target is optional we cannot count on it to order remote mounts after network.target, so let's add that order explicitly in addition to remote-fs-pre.target. https://bugzilla.redhat.com/show_bug.cgi?id=749940
2011-11-01cgroup: always recreate cgroup before we try to apply attributesLennart Poettering
We might have trimmed the cgroup tree previously, hence don't trust our own "realized" flag, always recreate cgroup tree before applying our attributes to make sure this actually works out. https://bugzilla.redhat.com/show_bug.cgi?id=749687
2011-11-01initctl: don't use dbus connection after PID 1 got respawnedLennart Poettering
After reexec PID 1 our bus connection is invalidated. Hence don't try to reuse it, just terminate so that when we are spawned the next time we just get a new one. Spotted by Marti Raudsepp.
2011-11-01condition: Fix file descriptor leak in test_capability()Thomas Jarosch
Detected by cppcheck.
2011-11-01random-seed: convert poolsize from bits to bytesTom Gundersen
The problem was first noted in a bug report against Arch's initscripts. Reported-by: Taylan Ulrich Bayırlı <taylanbayirli@gmail.com> Reported-by: Gerardo Exequiel Pozzi <vmlinuz386@yahoo.com.ar>
2011-11-01plymouth: fix ply proto endianess issuesLennart Poettering
Plymouth enforces LE even for the local Ply proto, hence we should do the conversion properly for BE arch compat. Tracked down by Harald Hoyer. https://bugzilla.redhat.com/show_bug.cgi?id=744415
2011-10-24systemctl: make list-unit-files output more economicalZbigniew Jędrzejewski-Szmek
The first column is given the width of the widest entry, if possible, otherwise all entries are ellipsized to fit in ($COLUMNS - (width of second column)). [ Added a few fixes, calculate state_cols too, respect '--no-legend', better handling of '--full' -- michich ]
2011-10-19systemctl-completion: always invoke with --no-legendDave Reisner
In the case of completion for the 'restart' verb, passing the invalid unit name (the colums header) causes completion to cease functioning entirely, with the error: Failed to issue method call: Unit name UNIT is not valid. This adds a small wrapper function for systemctl which can have common options added to it.
2011-10-17audit: do not complain if kernel lacks auditJonathan Nieder
When running on a kernel without audit support, systemd currently writes a mysterious-sounding error to its log: systemd[1]: Failed to connect to audit log: Protocol not supported Better to suppress the audit_open() failure message when (and only when) it is due to running on a kernel without audit support, since in this case the admin probably does not mind systemd not writing to the audit log. This way, more serious errors like ENOMEM and EACCES will stand out more.
2011-10-17service: Drop rcN.d runlevels from SysV services that also exist in rcS.dTollef Fog Heen
Services which claim to start in both rcN.d and rcS.d generate loops which for some reason seems to usually end up with dbus not starting and the whole machine being quite unhappy. We now rather assume that if a service can be started in rcS, it should not also start in rcN.d. Fixes Debian bug #637037
2011-10-17manager: fix a crash in isolatingMichal Schmidt
HASHMAP_FOREACH is safe against the removal of the current entry, but not against the removal of other entries. job_finish_and_invalidate() can recursively remove other entries. It triggered an assertion failure: Assertion 'j->installed' failed at src/manager.c:1218, function transaction_apply(). Aborting. Fix the crash by iterating from the beginning when there is a possibility that the iterator could be invalid. It is O(n^2) in the worst case, but that's better than a crash. https://bugzilla.redhat.com/show_bug.cgi?id=717325
2011-10-11util: properly detect what the last capability isLennart Poettering
2011-10-11service: don't try to guess PID for SysV services anymoreLennart Poettering
As it turns out there are quite a number of SysV services too broken to make the guessing work: instead of returning in the parent only after the child is fully initialized they return immediately. The effect is that the guessing in systemd might happen too early, at a time where the final main process doesn't exist yet. By turning this off we won't try to detect the main pid anymore, with the effect that all processes of the service in question are considered equally likely to be the main process.
generated by cgit v1.2.3-54-g00ecf (git 2.45.2) at 2024-11-15 03:42:01 +0000