summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2013-02-13efi: unify BootXXXX readingKay Sievers
2013-02-13Revert "log_error() if inotify_add_watch() fails"Lennart Poettering
This reverts commit 2826d14091e43ed3397d862dee79d09d0115c84e. We never should generate log messages from a library.
2013-02-13log_error() if inotify_add_watch() failsHarald Hoyer
[zj: Reworded message s/to watch/to add watch on/ to make it clear that it was the watch init action that failed, and not the "process of watching". I think this way it'll be clearer to people who don't know what inotify does.]
2013-02-13sysctl: fix uninitalized memory access in error pathZbigniew Jędrzejewski-Szmek
src/sysctl/sysctl.c: In function ‘parse_file’: src/sysctl/sysctl.c:172:41: warning: ‘property’ may be used uninitialized in this function [-Wmaybe-uninitialized]
2013-02-13man: rename systemd.conf to systemd-system.confZbigniew Jędrzejewski-Szmek
Alias as systemd-user.conf is also provided. This should help users running systemd in session mode. https://bugzilla.redhat.com/show_bug.cgi?id=690868
2013-02-13test-udev: include missing.hAleksander Morgado
We need MS_REC and MS_SHARED defined for a proper compilation, so get them from 'missing.h' if not defined already.
2013-02-13ratelimit: fix off-by-oneMichael Olbrich
The current code might make sense during startup for service restart limiting: With burst=1 after starting num is 1, so the next ('first') restart is still accepted ( 1 <= 1). However, once interval has expired, num is 1 after the first restart, so the second restart is also accepted. This change is also useful in combination with watchdogs: With burst=1 and a very large interval the system can be restarted on the first failure.
2013-02-13tests: add test for continuation lines with commentsZbigniew Jędrzejewski-Szmek
2013-02-13bootchart: Fix typos and some EnglishWilliam Giokas
bootchart.conf: direct users to `bootchart.conf(5)`, not a nonexistent man page. svg.c: Fix some English in the svg comment header. * Chrome/Chromium => Chrome, Chromium * firefox => Firefox * much more slow => more slowly
2013-02-13util: *DO NOT* loop for EINTR handling with close_nointr()Colin Walters
See the linked references for why we should not do this.
2013-02-13boot: add stub Makefile symlinkLennart Poettering
2013-02-12bootchart: make bootchart work from within the initrdHarald Hoyer
With this patch, bootchart can be started from within the initramfs via the kernel command line "rdinit=/usr/lib/systemd/systemd-bootchart" see: http://harald.fedorapeople.org/downloads/bootchart-20130207-1652.svg
2013-02-13journal: Don't use loginuid if it's not validColin Walters
Code above this attempted to load loginuid, if this failed for whatever reason, we'd still end up using that value (0) in place of realuid. Fix this by setting a bool when we know the loginuid is valid. This fixes journal messages showing up in per-user journals in gnome-ostree (not configured with loginuid, but I'll shortly fix that).
2013-02-13util: introduce strcaseeq/strncaseeqThomas Hindoe Paaboel Andersen
2013-02-13use strneq instead of strncmpThomas Hindoe Paaboel Andersen
2013-02-12Merge branch 'master' of ssh://git.freedesktop.org/git/systemd/systemd into workAuke Kok
2013-02-13efi: add missing #includeLennart Poettering
2013-02-13manager: pass environment over daemon-reexecOleksii Shevchuk
Fixes this bug: alxchk > systemctl --user set-environment A=B alxchk > systemctl --user show-environment | grep ^A= A=B alxchk > systemctl --user daemon-reexec alxchk > systemctl --user show-environment | grep ^A= alxchk >
2013-02-12systemd-bootchart: relicense to LGPLv2.1+Auke Kok
When we merged systemd-bootchart we omitted relicensing this to LGPL. Now that code is being used for other purposes we need to make sure the code is shareable within systemd without further problems. The original committers and contributors of bootchart before it was merged all have agreed with the relicensing.
2013-02-13efi: various cleanupsLennart Poettering
2013-02-13missing: define MS_REC and MS_SHARED if not defined alreadyAleksander Morgado
2013-02-12udev: use unique names for temporary files created in /devKay Sievers
On Tue, Feb 12, 2013 at 2:18 PM, Robert Milasan <rmilasan@suse.com> wrote: > Under some circumstances udev mixed with multipath fails: > > udevd-work[1376]: > symlink(../../sdk, /dev/disk/by-id/scsi-36005076305ffc0670000000000002842.udev-tmp) > failed: File exists udevd-work[1432]: > rename(/dev/disk/by-id/scsi-36005076305ffc0850000000000000a88.udev-tmp, /dev/disk/by-id/scsi-36005076305ffc0850000000000000a88) > failed: No such file or directory > > This is non-fatal, but there is no point of created the symlink or > renaming the symlink if it already exists. > > Reference: https://bugzilla.novell.com/show_bug.cgi?id=791503 It looke like this now: stat("/dev/disk/by-id", {st_mode=S_IFDIR|0755, st_size=80, ...}) = 0 symlink("../../sda", "/dev/disk/by-id/ata-INTEL...N.tmp-b8:0") = 0 rename("/dev/disk/by-id/ata-INTEL...N.tmp-b8:0", "/dev/disk/by-id/ata-INTEL...N") = 0
2013-02-12cdrom_id: add data track count for bad virtual drive implementationsHarald Hoyer
/# /lib/udev/cdrom_id --debug /dev/sr0 probing: '/dev/sr0' INQUIRY: [AMI ][Virtual CDROM ][1.00] GET CONFIGURATION failed with SK=5h/ASC=20h/ACQ=00h drive is pre-MMC2 and does not support 46h get configuration command trying to work around the problem READ DISC INFORMATION failed with SK=5h/ASC=20h/ACQ=00h no current profile, but disc is present; assuming CD-ROM READ TOC: len: 12, start track: 1, end track: 1 last track 1 starts at block 0 READ DISC INFORMATION failed with SK=5h/ASC=20h/ACQ=00h ID_CDROM=1 ID_CDROM_MEDIA=1 ID_CDROM_MEDIA_CD=1 What is missing here is ID_CDROM_MEDIA_TRACK_COUNT_DATA to trigger blkid in /lib/udev/rules.d/60-persistent-storage.rules KERNEL=="sr*", ENV{DISK_EJECT_REQUEST}!="?*", ENV{ID_CDROM_MEDIA_TRACK_COUNT_DATA}=="?*", ENV{ID_CDROM_MEDIA_SESSION_LAST_OFFSET}=="", \ IMPORT{builtin}="blkid --noraid"
2013-02-12localectl: fix --help textLennart Poettering
https://bugs.freedesktop.org/show_bug.cgi?id=60595
2013-02-12journalctl: allow both "-n 55" and "-n55" on the command line, as equivalent ↵Lennart Poettering
syntaxes https://bugs.freedesktop.org/show_bug.cgi?id=60596
2013-02-11manager: clean environment before passing it on to othersLennart Poettering
2013-02-11binfmt,tmpfiles,modules-load,sysctl: rework the various early-boot services ↵Lennart Poettering
that work on .d/ directories This unifies much of the logic behind them: - All four will now ofllow the rule that the earlier file and earlier assignment in the .d/ directories wins. Before, sysctl was the only outlier, where the later setting always won. - All four now support getopt() and --help on the command line. - All four can now handle specification of configuration file names on the command line to apply. The tools will automatically find them, and apply them. Previously only tmpfiles could do that. This is useful for %post scripts in RPMs and suchlike. - This fixes various error path issues in conf_files_list()
2013-02-11core: properly validate environment data from Environment= lines in unit filesLennart Poettering
2013-02-11manager: validate environment parameters for SetEnvironment(), ↵Lennart Poettering
UnsetEnvironment() bus calls
2013-02-11bootctl: print partition uuids as /dev/disk/by-partuuid/...Kay Sievers
2013-02-11core: don't accept invalid environment assignments from the kernel cmdlineLennart Poettering
2013-02-11tests: more testsThomas Hindoe Paaboel Andersen
tests for: parse_boolean env_name_is_valid Also convert assert to assert_se to make sure they are run even with optimization. (see commit 9b5d6bd909855543cba75a4469bff6f82845cf0d)
2013-02-11logind: Allow active sessions to always shutdown by defaultAdel Gadllah
Currently local user are being asked for an admin password when another user is logged into the system. This does not make sense as the user has the power to shut down the system anyway regardless if he/she knows the password or not (by pulling the plug, battery or whatever). So only require the admin authentification for remote sessions. https://bugzilla.gnome.org/show_bug.cgi?id=693385
2013-02-11bootctl: add boot loader and firmware interface toolKay Sievers
2013-02-11efi: fix returned length of efi_get_variable()Lennart Poettering
2013-02-11util: rework load_env_file()Lennart Poettering
Inner library calls should not invoke log_oom(), that's something for main programs, not library calls. Don't read through uninitialized memory if a file ends in a continuation line. Add comments for the non-obvious bits. Don't choke on comment lines that are continuation lines. Simplify some things.
2013-02-11path-util: fix memory leakLennart Poettering
2013-02-11util: introduce FOREACH_LINE for iterating through filesLennart Poettering
2013-02-11test-env-replace: better user assert_se() everywhereLennart Poettering
For test tools it's better to use assert_se() rather than assert(), since the former is not optimized away, even if -DNDEBUG is used. That means the test program now retains its usefulness even if -DNDEBUG is used. This also adds in some OOM checks, to be extra anal...
2013-02-11env: considerably beef up environment cleaning logicLennart Poettering
Now, actually check if the environment variable names and values used are valid, before accepting them. With this in place are at some places more rigid than POSIX, and less rigid at others. For example, this code allows lower-case environment variables (which POSIX suggests not to use), but it will not allow non-UTF8 variable values. All in all this should be a good middle ground of what to allow and what not to allow as environment variables. (This also splits out all environment related calls into env-util.[ch])
2013-02-10tests: add tests of strxcpyxThomas Hindoe Paaboel Andersen
also fix a bad indentation in test-strbug.c
2013-02-09vconsole-setup: don't set the kbd mode to unicode if is is currently in ↵Lennart Poettering
raw/off mode Let's not confuse X11
2013-02-09shutdown: issue a sync() as soon as shutdown.target is queuedLennart Poettering
2013-02-09tests: add test of strbufThomas Hindoe Paaboel Andersen
2013-02-09logind: rename "seat-master" tag to "master-of-seat"Lennart Poettering
We currently enforce that seats are to be named in the form of "seatXXX", i.e. need to begin with the 4 characters "seat". Thus, "seat-master" would qualify as a seat name. As seat names are frequently used as tags on devices, the "seat-master" tag might hence confuse logind if the user decides to name a seat "seat-master". Hence, avoid any ambuigity: let's rename the "seat-master" tag to "master-of-seat".
2013-02-08udev: udevadm hwdb - add --root=Kay Sievers
https://bugs.freedesktop.org/show_bug.cgi?id=60398
2013-02-08shared: conf-files - use root parameter and convert to auto-cleanupKay Sievers
2013-02-08shared: conf-files - add root parameterKay Sievers
2013-02-07systemd: fix uninitialized memory access in selinuxZbigniew Jędrzejewski-Szmek
==6129== Syscall param socketcall.getsockopt(optlen) points to uninitialised byte(s) ==6129== at 0x312D0F325A: getsockopt (syscall-template.S:81) ==6129== by 0x4615E6: get_audit_data (selinux-access.c:268) ==6129== by 0x461A81: selinux_access_check (selinux-access.c:394) ==6129== by 0x453B23: bus_manager_message_handler (dbus-manager.c:1395) ==6129== by 0x313581D9C4: _dbus_object_tree_dispatch_and_unlock (dbus-object-tree.c:862) ==6129== by 0x313580FC1F: dbus_connection_dispatch (dbus-connection.c:4672) ==6129== by 0x44CD4C: bus_dispatch (dbus.c:528) ==6129== by 0x41292F: manager_loop (manager.c:1573) ==6129== by 0x40CD8E: main (main.c:1735) ==6129== Address 0x7fefff2c0 is on thread 1's stack
2013-02-08tests: add more testsThomas Hindoe Paaboel Andersen
Adds tests of: strv_env_delete strv_env_unset strv_env_set