summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2011-11-17execute: log errors from "sd(EXEC)"Michal Schmidt
To give the administrator more hints about failures occuring in spawning of commands than just the exit code, log the strerror. All fds are closed, so reopen the log. Related-to: https://bugzilla.redhat.com/show_bug.cgi?id=752901
2011-11-17execute: make setup_pam() return -errno when possibleMichal Schmidt
The only caller currently checks if the result is non-zero, so nothing changes there.
2011-11-16execute: avoid logging to closed fdsMichal Schmidt
Several functions called from the "sd(EXEC)" process try to log messages when all the file descriptors are already closed, including the logging ones. The logging functions do not expect their fds to be closed and they hit an assertion failure. The failure wants to be logged too, so there is an infinite recursion, ended by a SIGSEGV. When we close all fds, we must let log.c know about it.
2011-11-14Fix same expression on both sides of '&&'Thomas Jarosch
The code should probably look like the statements above it. Please verify, I just detected it using cppcheck. Signed-off-by: Thomas Jarosch <thomas.jarosch@intra2net.com>
2011-11-11job: colored status messages on bootMichal Schmidt
The lack or green/red status marks on boot has been described by some users as "critical", "dramatic", "dealbreaker", "showstopper". Seriously.
2011-11-10service: don't warn if the pidfile still exists after SIGCHLDMichal Schmidt
A service that drops its privileges may not be able to remove it when it exits. The stale pidfile is not a problem as long as the service carefully recognizes it on its next start. systemd would produce a warning after the service exits: PID ... read from file ... does not exist. Your service or init script might be broken. Silence the warning in this case. Still warn if this error is detected when loading the pidfile after service start. Noticed by Miroslav Lichvar in https://bugzilla.redhat.com/show_bug.cgi?id=752396
2011-11-07utmp: for DEAD_PROCESS write the current time to wtmpMichal Schmidt
Zeroed .ut_tv values in wtmp confuse chkrootkit. Reported and debugged by Norman Smith. This is based on his patch, but modified to behave more like upstart did in F14 and cleaned up. https://bugzilla.redhat.com/show_bug.cgi?id=743696
2011-11-07utmp: initialize store with the found entry, not with the lookup keyMichal Schmidt
2011-11-07utmp: no need to zero a struct before overwriting it with memcpyMichal Schmidt
2011-11-07utmp: remove unneded parametersMichal Schmidt
With these functions no caller ever passes anything else than 0 for 't' (meaning the current time will be used).
2011-11-03cgroup: immediately remove all cgroups which run emptyLennart Poettering
Some controllers have scaling problems when many empty cgroups exist. Hence, as soon as we get a notification that a cgroup is empty, delete it. This is also nice to keep the systemd-cgls output short.
2011-11-02Merge remote-tracking branch 'zbigniew/systemadm_changes'Lennart Poettering
2011-11-02bash-completion: rename file since it is no longer for systemctl onlyRan Benita
2011-11-02bash-completion: add completions for systemd-loginctlRan Benita
This script is straightforward and should give proper completions for all of systemd-loginctl's verbs.
2011-11-02bash-completion: update with new verbs and argumentsRan Benita
Adds arguments --root= --runtime --no-legend. Adds verbs link mask unmask reenable list-unit-files. Also uses list-unit-files to make nicer enable and disable completions. Rebased due to changes in systemctl.
2011-11-02Add Mageia supportDexter Morgan
This patch adds support for the Mageia Linux distribution: http://www.mageia.org/ Mageia is a fork of Mandriva although some divergence has already occured and thus inclusion of these changes upstream allow us to (hopefully) migrate more rapidly to the new standard approaches systemd offers. Indeed, we already use the preferred mechanism of OS identification via the /etc/os-release file rather than a distro specific variation. This patch mostly mirrors the patch added previously for Mandriva support. In addition to those original authors, this patch was mostly written by Dexter Morgan with help from Colin Guthrie and Eugeni Dodonov.
2011-11-01cryptsetup-generator: avoid ordering cycle on swapTom Gundersen
Devices with random keys (swap), should not be ordered before local-fs.target, as this creates a cycle with systemd-load-random-seed.service (and also it does not make sense, a swap device is not a local-fs).
2011-11-01mount: order remote mounts after both network.target and remote-fs-pre.targetLennart Poettering
Since remote-fs-pre.target is optional we cannot count on it to order remote mounts after network.target, so let's add that order explicitly in addition to remote-fs-pre.target. https://bugzilla.redhat.com/show_bug.cgi?id=749940
2011-11-01cgroup: always recreate cgroup before we try to apply attributesLennart Poettering
We might have trimmed the cgroup tree previously, hence don't trust our own "realized" flag, always recreate cgroup tree before applying our attributes to make sure this actually works out. https://bugzilla.redhat.com/show_bug.cgi?id=749687
2011-11-01initctl: don't use dbus connection after PID 1 got respawnedLennart Poettering
After reexec PID 1 our bus connection is invalidated. Hence don't try to reuse it, just terminate so that when we are spawned the next time we just get a new one. Spotted by Marti Raudsepp.
2011-11-01condition: Fix file descriptor leak in test_capability()Thomas Jarosch
Detected by cppcheck.
2011-11-01random-seed: convert poolsize from bits to bytesTom Gundersen
The problem was first noted in a bug report against Arch's initscripts. Reported-by: Taylan Ulrich Bayırlı <taylanbayirli@gmail.com> Reported-by: Gerardo Exequiel Pozzi <vmlinuz386@yahoo.com.ar>
2011-11-01plymouth: fix ply proto endianess issuesLennart Poettering
Plymouth enforces LE even for the local Ply proto, hence we should do the conversion properly for BE arch compat. Tracked down by Harald Hoyer. https://bugzilla.redhat.com/show_bug.cgi?id=744415
2011-10-24systemctl: make list-unit-files output more economicalZbigniew Jędrzejewski-Szmek
The first column is given the width of the widest entry, if possible, otherwise all entries are ellipsized to fit in ($COLUMNS - (width of second column)). [ Added a few fixes, calculate state_cols too, respect '--no-legend', better handling of '--full' -- michich ]
2011-10-19systemctl-completion: always invoke with --no-legendDave Reisner
In the case of completion for the 'restart' verb, passing the invalid unit name (the colums header) causes completion to cease functioning entirely, with the error: Failed to issue method call: Unit name UNIT is not valid. This adds a small wrapper function for systemctl which can have common options added to it.
2011-10-17audit: do not complain if kernel lacks auditJonathan Nieder
When running on a kernel without audit support, systemd currently writes a mysterious-sounding error to its log: systemd[1]: Failed to connect to audit log: Protocol not supported Better to suppress the audit_open() failure message when (and only when) it is due to running on a kernel without audit support, since in this case the admin probably does not mind systemd not writing to the audit log. This way, more serious errors like ENOMEM and EACCES will stand out more.
2011-10-17service: Drop rcN.d runlevels from SysV services that also exist in rcS.dTollef Fog Heen
Services which claim to start in both rcN.d and rcS.d generate loops which for some reason seems to usually end up with dbus not starting and the whole machine being quite unhappy. We now rather assume that if a service can be started in rcS, it should not also start in rcN.d. Fixes Debian bug #637037
2011-10-17manager: fix a crash in isolatingMichal Schmidt
HASHMAP_FOREACH is safe against the removal of the current entry, but not against the removal of other entries. job_finish_and_invalidate() can recursively remove other entries. It triggered an assertion failure: Assertion 'j->installed' failed at src/manager.c:1218, function transaction_apply(). Aborting. Fix the crash by iterating from the beginning when there is a possibility that the iterator could be invalid. It is O(n^2) in the worst case, but that's better than a crash. https://bugzilla.redhat.com/show_bug.cgi?id=717325
2011-10-11util: properly detect what the last capability isLennart Poettering
2011-10-11service: don't try to guess PID for SysV services anymoreLennart Poettering
As it turns out there are quite a number of SysV services too broken to make the guessing work: instead of returning in the parent only after the child is fully initialized they return immediately. The effect is that the guessing in systemd might happen too early, at a time where the final main process doesn't exist yet. By turning this off we won't try to detect the main pid anymore, with the effect that all processes of the service in question are considered equally likely to be the main process.
2011-10-11localed: make sure s-s-k doesn't create any X11 config files anymoreLennart Poettering
2011-10-11localed: shorten generate-kbd-model-mapZbigniew Jędrzejewski-Szmek
Output is identical.
2011-10-11pager: add _noreturn_ to pager_fallback()Zbigniew Jędrzejewski-Szmek
src/pager.c: In function ‘pager_fallback’: src/pager.c:35:13: warning: function might be possible candidate for attribute ‘noreturn’ [-Wmissing-noreturn]
2011-10-11unit: introduce ConditionCapabilityLennart Poettering
2011-10-11logind: fail gracefully if too many sessions are createdLennart Poettering
https://bugzilla.redhat.com/show_bug.cgi?id=744726
2011-10-11timedate: fall back to /etc/sysconfig/clock on Fedora, for compatibility ↵Lennart Poettering
with legacy
2011-10-11units: introduce local-fs-pre.target and remote-fs-pre.targetLennart Poettering
This hook target enables services to order themselves between network.target and remote mounts, which is needed for GFS2 and similar systems.
2011-10-11sd-login.h: correct spelling mistakes in commentsDave Reisner
2011-10-11hostname-setup: Frugalware switched to /etc/hostnameMiklos Vajna
2011-10-11readahead: lower max file size for readaheadPaolo Bonzini
https://bugs.freedesktop.org/show_bug.cgi?id=41336
2011-10-10util: fix close() call on wrong variableThomas Jarosch
Detected by "cppcheck" (actually it detected a file descriptor leak)
2011-10-10tmpfiles: fix file descriptor leakThomas Jarosch
Detected by "cppcheck"
2011-10-09test_virtualization: do not try to compare id in !virt contextKay Sievers
2011-10-07hashmap: use different version of DJB's hash algorithm that uses shifting ↵Lennart Poettering
instead of multiplication
2011-10-04logind: properly generate session creation response on dbusLennart Poettering
This fixes the various reported issues with dbus message parsing when running su.
2011-09-29systemctl: fix corrupted output of unitsMichal Schmidt
On some systems the list of units in systemctl output came out wrong, all on one line and with missing descriptions. It turns out printf() really attempts to mmap 2G memory when INT_MAX is passed as the field width. On machines with small virtual memory without overcommit the mmap inside printf() failed. Do not use INT_MAX for unlimited width.
2011-09-29localed: handle multiple X11 kbd layoutsLennart Poettering
https://bugs.freedesktop.org/show_bug.cgi?id=41341
2011-09-29systemctl: fix error message when no connection to systemd is availableLennart Poettering
2011-09-29systemctl: fix detection whether the dbus connection is availableLennart Poettering
2011-09-28vconsole: don't parse Fedora's KEYMAP= kernel parameters anymoreLennart Poettering
KEYMAP are use to pass keymap configuration to initrd, but not to the system itself. Since the initrd might get out of date we need to make sure that changes made in userspace override the settings from the cmdline, hence drpo any use of it all for these variables.
generated by cgit v1.2.3-54-g00ecf (git 2.45.2) at 2024-11-14 18:09:43 +0000