summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2014-02-28cdrom_id: use the old MMC fallbackLukas Nykryn
https://bugzilla.redhat.com/show_bug.cgi?id=1038015 The problem seems to be that the your virtual DVD is emulating a really old DVD device, and doing it kind of strangely. > dracut:# /lib/udev/cdrom_id --debug /dev/sr0 > probing: '/dev/sr0' > INQUIRY: [IMM ][Virtual CD/DVD ][0316] > GET CONFIGURATION failed with SK=5h/ASC=24h/ACQ=00h So your virtual drive rejects the GET CONFIGURATION command as illegal. Other pre-MMC2 drives that don't accept this command usually return the error SK=5h,ASC=20h (invalid/unsupported command code), in which case cdrom_id tries an older method, and then ID_CDROM_MEDIA_TRACK_COUNT_DATA gets set and all the /dev/disk/by-label (etc) links get set up. The virtual drive returns the error SK=5h,ASC=24h (invalid field in Command Descriptor Block), which cdrom_id doesn't handle, so it gives up and the links never get made. The ideal solution would be to make the IMM to emulate a device that's less than 15 years old, but I'm not going to hold my breath waiting for that. So probably cdrom_id should also use the old MMC fallback when the error is SK=5h,ASC=24h, and then all of this would work as expected. Suggested-by:Luca Miccini <lmiccini@redhat.com> Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-02-28Remove dead lines in various placesZbigniew Jędrzejewski-Szmek
As pointed-out by clang -Wunreachable-code. No behaviour changes. Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-02-22gudev: add device::get_sysfs_attr_keys and device::has_sysfs_attrAndreas Fuchs
For gudev -> gudevdevice: - Add support for get_sysfs_attr_keys() - Add support for has_sysfs_attr() Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-02-21Add missing REENABLE_WARNING and unlink_noerrno()Anthony G. Basile
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-02-21macro: introduce a nice macro for disabling -Wformat-nonliteral temporarilyAnthony G. Basile
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-02-21udev: make sure we always return a valid error code in trie_store()Lennart Poettering
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-02-21make gcc shut upLennart Poettering
If -flto is used then gcc will generate a lot more warnings than before, among them a number of use-without-initialization warnings. Most of them without are false positives, but let's make them go away, because it doesn't really matter. Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-02-21doc: update punctuationJan Engelhardt
Resolve spotted issues related to missing or extraneous commas, dashes. Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-02-21Remove unused variable and two function stubsZbigniew Jędrzejewski-Szmek
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-02-21everywhere: always use O_CLOEXEC where it makes senseLennart Poettering
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-02-21everywhere: make use of new0() and macro() macros, and stop using perror()Lennart Poettering
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-02-09Update some message formatsZbigniew Jędrzejewski-Szmek
Use PID_FMT/USEC_FMT/... in more places. Also update logind error messages to print the full path to a file that failed. This should make debugging easier for people who do not know off the top of their head where logind stores it state. Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-02-02use memzero(foo, length); for all memset(foo, 0, length); callsGreg KH
In trying to track down a stupid linker bug, I noticed a bunch of memset() calls that should be using memzero() to make it more "obvious" that the options are correct (i.e. 0 is not the length, but the data to set). So fix up all current calls to memset(foo, 0, length) to memzero(foo, length). Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-01-27udev: static_node - do not exit rule after first static_node itemKay Sievers
The nodes usually do not exist, so handle the next item instead of skipping the entire rule. Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-01-25src/libudev/util.h: import FORMAT_TIMESPAN_MAX for selinuxAnthony G. Basile
When configure --enable-selinux, we hit a compile time error with a missing definition of FORMAT_TIMESPAN_MAX. This was imported from upstream's src/shared/time-util.h into our src/libudev/util.h. Thanks Amadeusz Sławiński <amade@asmblr.net> X-Gentoo-Bug: 499252 X-Gentoo-Bug-URL: https://bugs.gentoo.org/499252 Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-01-20libudev-util.c: Handle -1 return from sysconf(_SC_GET{PW,GR}_R_SIZE_MAX)Michael Forney
POSIX says: Note that sysconf(_SC_GETGR_R_SIZE_MAX) may return -1 if there is no hard limit on the size of the buffer needed to store all the groups returned. The example from POSIX uses a default buffer size of 1024 in that case. Signed-off-by: Michael Forney <mforney@mforney.org>
2014-01-20libudev-util.c: Fix sysconf variable for util_lookup_groupMichael Forney
Signed-off-by: Michael Forney <mforney@mforney.org>
2014-01-20udev/udevadm-hwdb.c: remove usage of qsort_rrofl0r
while theoretically a nice interface, qsort_r on GLIBC was implemented with a prototype that shuffles the argument order around when compared to the traditional BSD implementations, yielding in 2 separate incompatible implementations. even worse, the arguments are all of pointer type so one would not even notice that the order is wrong and so this would yield in crashes or silent memory corruption. thus musl does not implement it, because configure scripts would check for its existance and use it unconditionally, even when assuming the BSD version. a more portable solution is to use TLS via __thread, which any modern GCC should provide. (even 3.4.6 on x86/x86_64 does so). Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-01-20libudev/sparse-endian.h: include header which defines __bswap_XXrofl0r
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-01-20libudev/path-util.c: remove usage of canonicalize_file_name()rofl0r
this is a glibc specific alias for realpath(path, NULL). to be portable, we need to use the real thing which is even less verbose. Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-01-14src/libudev: bring in line with upstreamAnthony G. Basile
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-01-13src/udev: bring up to date with upstream.Anthony G. Basile
These commits were authored by Zbigniew Jędrzejewski-Szmek Tom Gundersen Kay Sievers Lennart Poettering Shawn Landden Daniel Buch Martin Pitt Karel Zak Yang Zhiyong Note: udev_builtin_net_setup_link has *not* been imported. Also still missing from udev-builtin is udev_builtin_uaccess. Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-01-11src/udev/path-util.[ch]: remove duplicatesAnthony G. Basile
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-01-09udev-builtin: path_id - add support for bcma busTom Gundersen
This matches the bcma support in the network device naming. Eventually wa want to make sure ID_PATH is equivalent to ID_NET_NAME_PATH, so we never need to match on the latter. Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-01-09udev: move udev_rules_check_timestamp to sharedTom Gundersen
I want to use this from a bulitin in a subsequent patch. Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-01-09udev: use initialization instead of zeroing in one placeZbigniew Jędrzejewski-Szmek
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-01-09Fix write-only use of a few variablesZbigniew Jędrzejewski-Szmek
Since the invention of read-only memory, write-only memory has been considered deprecated. Where appropriate, either make use of the value, or avoid writing it, to make it clear that it is not used. Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-01-09udev: usb_id - remove obsoleted bInterfaceSubClass == 5 matchKay Sievers
bInterfaceSubClass == 5 is not a "floppy"; just identify the obsolete QIC-157 interface as "generic". Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-01-09smack: minimize ifdef use, and move all labeling to smack-util.cKay Sievers
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-01-09security: rework selinux, smack, ima, apparmor detection logicLennart Poettering
Always cache the results, and bypass low-level security calls when the respective subsystem is not enabled. Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-01-09udev: add SECLABEL{selinux}= supportKay Sievers
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-01-09udev: reset Linux Security Module labels if no custom rules are givenKay Sievers
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-01-09udev: support custom Linux Security Module labels for device nodesKay Sievers
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-01-09udev-builtin-blkid: export ID_PART_TABLE_UUIDDave Reisner
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-01-09udev: path_id - fix by-path link generation for scm devicesSebastian Ott
Set some_transport = true to prevent scm devices from being ignored. Suggested-by: Harald Hoyer <harald@redhat.com> Signed-off-by: Sebastian Ott <sebott@linux.vnet.ibm.com> Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-01-09udev-rules: avoid erroring on trailing whitespaceDave Reisner
https://bugs.archlinux.org/task/36950 Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-01-09libudev: ship the original MurmurHash2.[ch] fileKay Sievers
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-01-09src/libudev/util.h: add missing FOREACH_LINEAnthony G. Basile
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-01-09libudev: monitor - only disallow "udev" type eventsKay Sievers
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-01-09libudev: disable monitor inside a containerKay Sievers
Uevents are events of the host, which should not leak into a container. Containers do not support hotplug at the moment, and devices and uevents are not namespace aware. Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-01-09bus: catch up with kdbus changesKay Sievers
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-01-09libudev: devices received from udev are always initializedKay Sievers
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-01-09Add more _printf_'s for format-nonliteralsThomas Hindoe Paaboel Andersen
Clang is a bit more strict wrt format-nonliterals: http://clang.llvm.org/docs/LanguageExtensions.html#format-string-checking Adding these extra printf attributes also makes gcc able to find more problems. E.g. this patch uncovers a format issue in udev-builtin-path_id.c Some parts looked intetional about breaking the format-nonliteral check. I added some supression for warnings there. Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-01-09libudev: hwdb - use libudev not systemd loggingKay Sievers
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-01-09docs: remove unneeded the's in gudev docsZbigniew Jędrzejewski-Szmek
https://bugs.freedesktop.org/show_bug.cgi?id=72164 Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-01-09libudev: always return NULL in _unref() APIsLennart Poettering
Returning anything else but NULL would suggest the caller's reference might still be valid, but it isn't, because the caller just invoked _unref() after all. This turns the return value into a typesafe shortcut that allows unreffing and resetting a reference in one line. In contrast to solutions for this which take a pointer to a pointer to accomplish the same this solution is just syntactic sugar the developer can make use of but doesn't have to, and this is particularly useful when immediately unreffing objects returned by function calls. Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-01-09libudev: always return valid negative error codes on API functionsLennart Poettering
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-01-09Remove duplicate includesKarel Zak
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-01-09udev: declare some symbols staticKay Sievers
2014-01-09udev: declare some symbols staticKay Sievers
generated by cgit v1.2.3-54-g00ecf (git 2.45.2) at 2024-11-07 08:57:39 +0000