From e28c7cd0665364bb910fe2cead882623c23c28ac Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Wed, 30 Nov 2016 15:07:43 +0100 Subject: tree-wide: set SA_RESTART for signal handlers we install We already set it in most cases, but make sure to set it in all others too, and document that that's a good idea. --- CODING_STYLE | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'CODING_STYLE') diff --git a/CODING_STYLE b/CODING_STYLE index e89b3c67e5..ed61ea9d28 100644 --- a/CODING_STYLE +++ b/CODING_STYLE @@ -429,3 +429,8 @@ and Linux/GNU-specific APIs, we generally prefer the POSIX APIs. If there aren't, we are happy to use GNU or Linux APIs, and expect non-GNU implementations of libc to catch up with glibc. + +- Whenever installing a signal handler, make sure to set SA_RESTART for it, so + that interrupted system calls are automatically restarted, and we minimize + hassles with handling EINTR (in particular as EINTR handling is pretty broken + on Linux). -- cgit v1.2.3-54-g00ecf