From eef46c372f64f40dd75415b2c504c73138719c8d Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Wed, 11 Feb 2015 18:50:38 +0100 Subject: tree-wide: whenever we include libgen.h, immediately undefine basename() Also, document in adjacent comments and in CODING_STYLE why we do that. --- CODING_STYLE | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'CODING_STYLE') diff --git a/CODING_STYLE b/CODING_STYLE index 1d1d970492..5574013487 100644 --- a/CODING_STYLE +++ b/CODING_STYLE @@ -202,3 +202,9 @@ b) socket() and socketpair() must get SOCK_CLOEXEC passed c) recvmsg() must get MSG_CMSG_CLOEXEC set d) F_DUPFD_CLOEXEC should be used instead of F_DUPFD, and so on + +- We never use the XDG version of basename(). glibc defines it in + libgen.h. The only reason to include that file is because dirname() + is needed. Everytime you need that please immediately undefine + basename(), and add a comment about it, so that no code ever ends up + using the XDG version! -- cgit v1.2.3-54-g00ecf