From 953bf4604f5ce02d1bd8abb09e82ea80e101c8a3 Mon Sep 17 00:00:00 2001 From: Zbigniew Jędrzejewski-Szmek Date: Tue, 29 Nov 2016 01:29:02 -0500 Subject: units: add system-update-cleanup.service to guard against offline-update loops Note: the name is "system-update-cleanup.service" rather than "system-update-done.service", because it should not run normally, and also because there's already "systemd-update-done.service", and having them named so similarly would be confusing. In https://bugzilla.redhat.com/show_bug.cgi?id=1395686 the system repeatedly entered system-update.target on boot. Because of a packaging issue, the tool that created the /system-update symlink could be installed without the service unit that was supposed to perform the upgrade (and remove the symlink). In fact, if there are no units in system-update.target, and /system-update symlink is created, systemd always "hangs" in system-update.target. This is confusing for users, because there's no feedback what is happening, and fixing this requires starting an emergency shell somehow, and also knowing that the symlink must be removed. We should be more resilient in this case, and remove the symlink automatically ourselves, if there are no upgrade service to handle it. This adds a service which is started after system-update.target is reached and the symlink still exists. It nukes the symlink and reboots the machine. It should subsequently boot into the default default.target. This is a more general fix for https://bugzilla.redhat.com/show_bug.cgi?id=1395686 (the packaging issue was already fixed). --- Makefile.am | 2 ++ 1 file changed, 2 insertions(+) (limited to 'Makefile.am') diff --git a/Makefile.am b/Makefile.am index 5cec19fbb8..6c350b0ec4 100644 --- a/Makefile.am +++ b/Makefile.am @@ -529,6 +529,7 @@ nodist_systemunit_DATA = \ units/serial-getty@.service \ units/console-getty.service \ units/container-getty@.service \ + units/system-update-cleanup.service \ units/systemd-initctl.service \ units/systemd-remount-fs.service \ units/systemd-ask-password-wall.service \ @@ -592,6 +593,7 @@ EXTRA_DIST += \ units/console-getty.service.m4.in \ units/container-getty@.service.m4.in \ units/rescue.service.in \ + units/system-update-cleanup.service.in \ units/systemd-initctl.service.in \ units/systemd-remount-fs.service.in \ units/systemd-update-utmp.service.in \ -- cgit v1.2.3-54-g00ecf