From 88fae6e0441d4195e089434f07d3e7fd811d6297 Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Thu, 23 Aug 2012 18:47:01 +0200 Subject: shared: in code that might get called from suid programs use __secure_getenv() rather than getenv() It's better to be safe than sorry. --- TODO | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'TODO') diff --git a/TODO b/TODO index b1b57d66ff..a4643d7b83 100644 --- a/TODO +++ b/TODO @@ -65,8 +65,6 @@ Features: * maybe make systemd-detect-virt suid? or use fscaps? -* consider using __secure_getenv() instead of getenv() in libs - * man: document in ExecStart= explicitly that we don't take shell command lines, only executable names with arguments * shutdown: don't read-only mount anything when running in container @@ -505,6 +503,8 @@ Regularly: * set_put(), hashmap_put() return values check. i.e. == 0 doesn't free()! +* use __secure_getenv() instead of getenv() where appropriate + Scheduled for removal (or fixing): * xxxOverridable dependencies -- cgit v1.2.3-54-g00ecf