From b6a2637524e4b94ba51abcf5ee42f3676c9755ed Mon Sep 17 00:00:00 2001 From: Kay Sievers Date: Thu, 10 Sep 2009 02:08:05 +0200 Subject: put util_create_path() and file creastion in a retry loop On 8/29/09, Florian Zumbiehl wrote: > Could it happen that > util_create_path() and util_delete_path() > do run in parallel for > the same directory? After all, util_create_path() > does handle > the case where creation of the directory happens in parallel > to it running, so it doesn't seem all that unlikely to me ... --- libudev/libudev-queue-private.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) (limited to 'libudev/libudev-queue-private.c') diff --git a/libudev/libudev-queue-private.c b/libudev/libudev-queue-private.c index d9f7a67d18..4e67a1f9d0 100644 --- a/libudev/libudev-queue-private.c +++ b/libudev/libudev-queue-private.c @@ -45,9 +45,9 @@ #include #include #include +#include #include #include -#include #include "libudev.h" #include "libudev-private.h" @@ -396,6 +396,7 @@ static void update_failed(struct udev_queue_export *udev_queue_export, { struct udev *udev = udev_device_get_udev(udev_device); char filename[UTIL_PATH_SIZE]; + int err; if (state != DEVICE_FAILED && udev_queue_export->failed_count == 0) return; @@ -408,10 +409,14 @@ static void update_failed(struct udev_queue_export *udev_queue_export, case DEVICE_FAILED: /* record event in the failed directory */ udev_queue_export->failed_count++; - util_create_path(udev, filename); - udev_selinux_setfscreatecon(udev, filename, S_IFLNK); - symlink(udev_device_get_devpath(udev_device), filename); - udev_selinux_resetfscreatecon(udev); + do { + util_create_path(udev, filename); + udev_selinux_setfscreatecon(udev, filename, S_IFLNK); + err = symlink(udev_device_get_devpath(udev_device), filename); + if (err != 0) + err = errno; + udev_selinux_resetfscreatecon(udev); + } while (err == ENOENT); break; case DEVICE_QUEUED: -- cgit v1.2.3-54-g00ecf