From 0a1beeb64207eaa88ab9236787b1cbc2f704ae14 Mon Sep 17 00:00:00 2001 From: Michal Schmidt Date: Fri, 28 Nov 2014 11:58:34 +0100 Subject: treewide: auto-convert the simple cases to log_*_errno() As a followup to 086891e5c1 "log: add an "error" parameter to all low-level logging calls and intrdouce log_error_errno() as log calls that take error numbers", use sed to convert the simple cases to use the new macros: find . -name '*.[ch]' | xargs sed -r -i -e \ 's/log_(debug|info|notice|warning|error|emergency)\("(.*)%s"(.*), strerror\(-([a-zA-Z_]+)\)\);/log_\1_errno(-\4, "\2%m"\3);/' Multi-line log_*() invocations are not covered. And we also should add log_unit_*_errno(). --- src/activate/activate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/activate') diff --git a/src/activate/activate.c b/src/activate/activate.c index 0a1df37f35..f4f41ed36c 100644 --- a/src/activate/activate.c +++ b/src/activate/activate.c @@ -103,7 +103,7 @@ static int open_sockets(int *epoll_fd, bool accept) { fd = make_socket_fd(LOG_DEBUG, *address, SOCK_STREAM | (arg_accept*SOCK_CLOEXEC)); if (fd < 0) { log_open(); - log_error("Failed to open '%s': %s", *address, strerror(-fd)); + log_error_errno(-fd, "Failed to open '%s': %m", *address); return fd; } -- cgit v1.2.3-54-g00ecf