From b9a8d250810d4803bc9bf6b36932b528cb991d1e Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Sun, 23 Aug 2015 14:33:50 +0200 Subject: machined: validate machine names at more places When enumerating machines from /run, and when accepting machine names for operations, be more strict and always validate. Note that these checks are strictly speaking unnecessary, since enumeration happens only on the trusted /run... --- src/basic/util.c | 3 +++ 1 file changed, 3 insertions(+) (limited to 'src/basic') diff --git a/src/basic/util.c b/src/basic/util.c index deff68073c..f752595ca1 100644 --- a/src/basic/util.c +++ b/src/basic/util.c @@ -4913,6 +4913,9 @@ int container_get_leader(const char *machine, pid_t *pid) { assert(machine); assert(pid); + if (!machine_name_is_valid(machine)) + return -EINVAL; + p = strjoina("/run/systemd/machines/", machine); r = parse_env_file(p, NEWLINE, "LEADER", &s, "CLASS", &class, NULL); if (r == -ENOENT) -- cgit v1.2.3-54-g00ecf