From 56f64d95763a799ba4475daf44d8e9f72a1bd474 Mon Sep 17 00:00:00 2001 From: Michal Schmidt Date: Fri, 28 Nov 2014 19:29:59 +0100 Subject: treewide: use log_*_errno whenever %m is in the format string If the format string contains %m, clearly errno must have a meaningful value, so we might as well use log_*_errno to have ERRNO= logged. Using: find . -name '*.[ch]' | xargs sed -r -i -e \ 's/log_(debug|info|notice|warning|error|emergency)\((".*%m.*")/log_\1_errno(errno, \2/' Plus some whitespace, linewrap, and indent adjustments. --- src/core/path.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'src/core/path.c') diff --git a/src/core/path.c b/src/core/path.c index 202cba5d31..ed03635a46 100644 --- a/src/core/path.c +++ b/src/core/path.c @@ -136,7 +136,7 @@ int path_spec_watch(PathSpec *s, sd_event_io_handler_t handler) { } if (!exists) { - log_error("Failed to add watch on any of the components of %s: %m", + log_error_errno(errno, "Failed to add watch on any of the components of %s: %m", s->path); r = -errno; /* either EACCESS or ENOENT */ goto fail; @@ -169,7 +169,7 @@ int path_spec_fd_event(PathSpec *s, uint32_t revents) { } if (ioctl(s->inotify_fd, FIONREAD, &l) < 0) { - log_error("FIONREAD failed: %m"); + log_error_errno(errno, "FIONREAD failed: %m"); return -errno; } @@ -181,7 +181,7 @@ int path_spec_fd_event(PathSpec *s, uint32_t revents) { k = read(s->inotify_fd, buf, l); if (k < 0) { - log_error("Failed to read inotify event: %m"); + log_error_errno(errno, "Failed to read inotify event: %m"); return -errno; } -- cgit v1.2.3-54-g00ecf