From 82a2b6bb5e4e5d294f09af778c48974a7857afb6 Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Wed, 28 Jan 2015 15:07:13 +0100 Subject: core: output unit status output strings to console, only if we actually are changing unit state Unit _start() and _stop() implementations can fail with -EAGAIN to delay execution temporarily. Thus, we should not output status messages before invoking these calls, but after, and only when we know that the invocation actually made a change. --- src/core/slice.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/core/slice.c') diff --git a/src/core/slice.c b/src/core/slice.c index a31e629370..ae9819d015 100644 --- a/src/core/slice.c +++ b/src/core/slice.c @@ -187,7 +187,7 @@ static int slice_start(Unit *u) { unit_realize_cgroup(u); slice_set_state(t, SLICE_ACTIVE); - return 0; + return 1; } static int slice_stop(Unit *u) { @@ -200,7 +200,7 @@ static int slice_stop(Unit *u) { * unit_notify() will do that for us anyway. */ slice_set_state(t, SLICE_DEAD); - return 0; + return 1; } static int slice_kill(Unit *u, KillWho who, int signo, sd_bus_error *error) { -- cgit v1.2.3-54-g00ecf