From 82a2b6bb5e4e5d294f09af778c48974a7857afb6 Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Wed, 28 Jan 2015 15:07:13 +0100 Subject: core: output unit status output strings to console, only if we actually are changing unit state Unit _start() and _stop() implementations can fail with -EAGAIN to delay execution temporarily. Thus, we should not output status messages before invoking these calls, but after, and only when we know that the invocation actually made a change. --- src/core/snapshot.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/core/snapshot.c') diff --git a/src/core/snapshot.c b/src/core/snapshot.c index 068a077f15..b70c3beb60 100644 --- a/src/core/snapshot.c +++ b/src/core/snapshot.c @@ -111,7 +111,7 @@ static int snapshot_start(Unit *u) { if (s->cleanup) unit_add_to_cleanup_queue(u); - return 0; + return 1; } static int snapshot_stop(Unit *u) { @@ -121,7 +121,7 @@ static int snapshot_stop(Unit *u) { assert(s->state == SNAPSHOT_ACTIVE); snapshot_set_state(s, SNAPSHOT_DEAD); - return 0; + return 1; } static int snapshot_serialize(Unit *u, FILE *f, FDSet *fds) { -- cgit v1.2.3-54-g00ecf