From 5261ba901845c084de5a8fd06500ed09bfb0bd80 Mon Sep 17 00:00:00 2001 From: Timofey Titovets Date: Fri, 15 Aug 2014 02:05:47 +0300 Subject: core: Refuse mount on symlink --- src/core/mount.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) (limited to 'src/core') diff --git a/src/core/mount.c b/src/core/mount.c index 39a9aaf2a0..ec90b0a670 100644 --- a/src/core/mount.c +++ b/src/core/mount.c @@ -827,6 +827,23 @@ void warn_if_dir_nonempty(const char *unit, const char* where) { NULL); } +static int fail_if_symlink(const char *unit, const char* where) { + assert(where); + + if (is_symlink(where) > 0) { + log_struct_unit(LOG_WARNING, + unit, + "MESSAGE=%s: Mount on symlink %s not allowed.", + unit, where, + "WHERE=%s", where, + MESSAGE_ID(SD_MESSAGE_OVERMOUNTING), + NULL); + + return -ELOOP; + } + return 0; +} + static void mount_enter_unmounting(Mount *m) { int r; @@ -877,6 +894,10 @@ static void mount_enter_mounting(Mount *m) { if (p && mount_is_bind(p)) mkdir_p_label(p->what, m->directory_mode); + r = fail_if_symlink(m->meta.id, m->where); + if (r < 0) + goto fail; + if (m->from_fragment) r = exec_command_set( m->control_command, -- cgit v1.2.3-54-g00ecf