From c79bb9e4e2e5b96b2ae2c432bf8b0ff9674fce60 Mon Sep 17 00:00:00 2001 From: Zbigniew Jędrzejewski-Szmek Date: Mon, 22 Apr 2013 20:51:29 -0400 Subject: Standarize on one spelling of symlink error message It's polite to print the name of the link that wasn't created, and it makes little sense to print the target. --- src/core/mount-setup.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'src/core') diff --git a/src/core/mount-setup.c b/src/core/mount-setup.c index a0fd7a078f..89adb0b4a3 100644 --- a/src/core/mount-setup.c +++ b/src/core/mount-setup.c @@ -334,7 +334,7 @@ int mount_cgroup_controllers(char ***join_controllers) { char **i; for (i = *k; *i; i++) { - char *t; + _cleanup_free_ char *t; t = strappend("/sys/fs/cgroup/", *i); if (!t) { @@ -344,10 +344,8 @@ int mount_cgroup_controllers(char ***join_controllers) { } r = symlink(options, t); - free(t); - if (r < 0 && errno != EEXIST) { - log_error("Failed to create symlink: %m"); + log_error("Failed to create symlink %s: %m", t); r = -errno; free(options); goto finish; -- cgit v1.2.3-54-g00ecf