From f5f6d0e25574dd63fb605b81fa7767dd71c454db Mon Sep 17 00:00:00 2001 From: Daniel Buch Date: Tue, 26 Nov 2013 09:38:02 +0100 Subject: tree-wide usage of %m specifier instead of strerror(errno) Also for log_error() except where a specific error is specified e.g. errno ? strerror(errno) : "Some user specified message" --- src/journal/coredumpctl.c | 2 +- src/journal/journald-console.c | 4 ++-- src/journal/journald-kmsg.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) (limited to 'src/journal') diff --git a/src/journal/coredumpctl.c b/src/journal/coredumpctl.c index bcfee46da1..ec65ff5221 100644 --- a/src/journal/coredumpctl.c +++ b/src/journal/coredumpctl.c @@ -479,7 +479,7 @@ static int run_gdb(sd_journal *j) { sz = write(fd, data, len); if (sz < 0) { - log_error("Failed to write temporary file: %s", strerror(errno)); + log_error("Failed to write temporary file: %m"); r = -errno; goto finish; } diff --git a/src/journal/journald-console.c b/src/journal/journald-console.c index 1ee3afeacc..04c4424a46 100644 --- a/src/journal/journald-console.c +++ b/src/journal/journald-console.c @@ -100,12 +100,12 @@ void server_forward_console( fd = open_terminal(tty, O_WRONLY|O_NOCTTY|O_CLOEXEC); if (fd < 0) { - log_debug("Failed to open %s for logging: %s", tty, strerror(errno)); + log_debug("Failed to open %s for logging: %m", tty); goto finish; } if (writev(fd, iovec, n) < 0) - log_debug("Failed to write to %s for logging: %s", tty, strerror(errno)); + log_debug("Failed to write to %s for logging: %m", tty); close_nointr_nofail(fd); diff --git a/src/journal/journald-kmsg.c b/src/journal/journald-kmsg.c index 21649d06ce..af49d8578a 100644 --- a/src/journal/journald-kmsg.c +++ b/src/journal/journald-kmsg.c @@ -88,7 +88,7 @@ void server_forward_kmsg( IOVEC_SET_STRING(iovec[n++], "\n"); if (writev(s->dev_kmsg_fd, iovec, n) < 0) - log_debug("Failed to write to /dev/kmsg for logging: %s", strerror(errno)); + log_debug("Failed to write to /dev/kmsg for logging: %m"); free(ident_buf); } -- cgit v1.2.3-54-g00ecf