From d6bd972d061af306ede2affd2c9340a1660f7996 Mon Sep 17 00:00:00 2001 From: Tom Gundersen Date: Sat, 21 Jun 2014 14:39:36 +0200 Subject: sd-dhcp-server: fix broadcast of DHCP packets The destination IP address should be INADDR_BROADCAST, but was accidentally left as INADDR_ANY. --- src/libsystemd-network/sd-dhcp-server.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'src/libsystemd-network/sd-dhcp-server.c') diff --git a/src/libsystemd-network/sd-dhcp-server.c b/src/libsystemd-network/sd-dhcp-server.c index e4236e8f7d..55a8fbe005 100644 --- a/src/libsystemd-network/sd-dhcp-server.c +++ b/src/libsystemd-network/sd-dhcp-server.c @@ -340,9 +340,12 @@ int dhcp_server_send_packet(sd_dhcp_server *server, } else if (req->message->ciaddr && type != DHCP_NAK) destination = req->message->ciaddr; - if (destination || requested_broadcast(req) || type == DHCP_NAK) + if (destination != INADDR_ANY) return dhcp_server_send_udp(server, destination, &packet->dhcp, sizeof(DHCPMessage) + optoffset); + else if (requested_broadcast(req) || type == DHCP_NAK) + return dhcp_server_send_udp(server, INADDR_BROADCAST, &packet->dhcp, + sizeof(DHCPMessage) + optoffset); else /* we cannot send UDP packet to specific MAC address when the address is not yet configured, so must fall back to raw packets */ -- cgit v1.2.3-54-g00ecf