From da927ba997d68401563b927f92e6e40e021a8e5c Mon Sep 17 00:00:00 2001 From: Michal Schmidt Date: Fri, 28 Nov 2014 13:19:16 +0100 Subject: treewide: no need to negate errno for log_*_errno() It corrrectly handles both positive and negative errno values. --- src/libsystemd/sd-rtnl/rtnl-util.c | 4 ++-- src/libsystemd/sd-rtnl/test-rtnl.c | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) (limited to 'src/libsystemd/sd-rtnl') diff --git a/src/libsystemd/sd-rtnl/rtnl-util.c b/src/libsystemd/sd-rtnl/rtnl-util.c index 1adfbb8643..bd97ba9ae7 100644 --- a/src/libsystemd/sd-rtnl/rtnl-util.c +++ b/src/libsystemd/sd-rtnl/rtnl-util.c @@ -157,11 +157,11 @@ bool rtnl_message_type_is_addr(uint16_t type) { } int rtnl_log_parse_error(int r) { - log_error_errno(-r, "Failed to parse netlink message: %m"); + log_error_errno(r, "Failed to parse netlink message: %m"); return r; } int rtnl_log_create_error(int r) { - log_error_errno(-r, "Failed to create netlink message: %m"); + log_error_errno(r, "Failed to create netlink message: %m"); return r; } diff --git a/src/libsystemd/sd-rtnl/test-rtnl.c b/src/libsystemd/sd-rtnl/test-rtnl.c index d77bce45cc..72d8fe2273 100644 --- a/src/libsystemd/sd-rtnl/test-rtnl.c +++ b/src/libsystemd/sd-rtnl/test-rtnl.c @@ -135,7 +135,7 @@ static void test_route(void) { r = sd_rtnl_message_new_route(NULL, &req, RTM_NEWROUTE, AF_INET, RTPROT_STATIC); if (r < 0) { - log_error_errno(-r, "Could not create RTM_NEWROUTE message: %m"); + log_error_errno(r, "Could not create RTM_NEWROUTE message: %m"); return; } @@ -143,13 +143,13 @@ static void test_route(void) { r = sd_rtnl_message_append_in_addr(req, RTA_GATEWAY, &addr); if (r < 0) { - log_error_errno(-r, "Could not append RTA_GATEWAY attribute: %m"); + log_error_errno(r, "Could not append RTA_GATEWAY attribute: %m"); return; } r = sd_rtnl_message_append_u32(req, RTA_OIF, index); if (r < 0) { - log_error_errno(-r, "Could not append RTA_OIF attribute: %m"); + log_error_errno(r, "Could not append RTA_OIF attribute: %m"); return; } @@ -223,7 +223,7 @@ static int pipe_handler(sd_rtnl *rtnl, sd_rtnl_message *m, void *userdata) { r = sd_rtnl_message_get_errno(m); - log_info_errno(-r, "%d left in pipe. got reply: %m", *counter); + log_info_errno(r, "%d left in pipe. got reply: %m", *counter); assert_se(r >= 0); -- cgit v1.2.3-54-g00ecf