From 8f077bf94e129fa1b6f0159e3140c4326f1066cf Mon Sep 17 00:00:00 2001 From: Zbigniew Jędrzejewski-Szmek Date: Sat, 26 Jul 2014 14:59:52 -0400 Subject: Print kdbus path when opening fails This makes it easier to debug what is going on. --- src/libsystemd/sd-bus/bus-kernel.c | 15 ++++++++++++--- src/libsystemd/sd-bus/bus-kernel.h | 2 +- 2 files changed, 13 insertions(+), 4 deletions(-) (limited to 'src/libsystemd') diff --git a/src/libsystemd/sd-bus/bus-kernel.c b/src/libsystemd/sd-bus/bus-kernel.c index f49fb5b394..8b961c38eb 100644 --- a/src/libsystemd/sd-bus/bus-kernel.c +++ b/src/libsystemd/sd-bus/bus-kernel.c @@ -1402,11 +1402,20 @@ static int bus_kernel_translate_policy(const BusNamePolicy *policy, struct kdbus return 0; } -int bus_kernel_open_bus_fd(const char *bus) { +int bus_kernel_open_bus_fd(const char *bus, char **path) { char *p; int fd; + size_t len; - p = alloca(strlen("/dev/kdbus/") + DECIMAL_STR_MAX(uid_t) + 1 + strlen(bus) + strlen("/bus") + 1); + len = strlen("/dev/kdbus/") + DECIMAL_STR_MAX(uid_t) + 1 + strlen(bus) + strlen("/bus") + 1; + + if (path) { + p = malloc(len); + if (!p) + return -ENOMEM; + *path = p; + } else + p = alloca(len); sprintf(p, "/dev/kdbus/" UID_FMT "-%s/bus", getuid(), bus); fd = open(p, O_RDWR|O_NOCTTY|O_CLOEXEC); @@ -1549,7 +1558,7 @@ int bus_kernel_create_monitor(const char *bus) { assert(bus); - fd = bus_kernel_open_bus_fd(bus); + fd = bus_kernel_open_bus_fd(bus, NULL); if (fd < 0) return fd; diff --git a/src/libsystemd/sd-bus/bus-kernel.h b/src/libsystemd/sd-bus/bus-kernel.h index 2fe2495a6c..87f98c58bf 100644 --- a/src/libsystemd/sd-bus/bus-kernel.h +++ b/src/libsystemd/sd-bus/bus-kernel.h @@ -65,7 +65,7 @@ int bus_kernel_take_fd(sd_bus *b); int bus_kernel_write_message(sd_bus *bus, sd_bus_message *m, bool hint_sync_call); int bus_kernel_read_message(sd_bus *bus, bool hint_priority, int64_t priority); -int bus_kernel_open_bus_fd(const char *bus); +int bus_kernel_open_bus_fd(const char *bus, char **path); int bus_kernel_make_starter(int fd, const char *name, bool activating, bool accept_fd, BusNamePolicy *policy, BusNamePolicyAccess world_policy); int bus_kernel_create_bus(const char *name, bool world, char **s); -- cgit v1.2.3-54-g00ecf