From da927ba997d68401563b927f92e6e40e021a8e5c Mon Sep 17 00:00:00 2001 From: Michal Schmidt Date: Fri, 28 Nov 2014 13:19:16 +0100 Subject: treewide: no need to negate errno for log_*_errno() It corrrectly handles both positive and negative errno values. --- src/machine/machinectl.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) (limited to 'src/machine/machinectl.c') diff --git a/src/machine/machinectl.c b/src/machine/machinectl.c index 7ef6244c62..52cdfda627 100644 --- a/src/machine/machinectl.c +++ b/src/machine/machinectl.c @@ -415,7 +415,7 @@ static int show_info(const char *verb, sd_bus *bus, const char *path, bool *new_ map, &info); if (r < 0) { - log_error_errno(-r, "Could not get properties: %m"); + log_error_errno(r, "Could not get properties: %m"); return r; } @@ -445,7 +445,7 @@ static int show_properties(sd_bus *bus, const char *path, bool *new_line) { r = bus_print_all_properties(bus, "org.freedesktop.machine1", path, arg_property, arg_all); if (r < 0) - log_error_errno(-r, "Could not get properties: %m"); + log_error_errno(r, "Could not get properties: %m"); return r; } @@ -682,13 +682,13 @@ static int login_machine(sd_bus *bus, char **args, unsigned n) { r = sd_event_default(&event); if (r < 0) { - log_error_errno(-r, "Failed to get event loop: %m"); + log_error_errno(r, "Failed to get event loop: %m"); return r; } r = sd_bus_attach_event(bus, event, 0); if (r < 0) { - log_error_errno(-r, "Failed to attach bus to event loop: %m"); + log_error_errno(r, "Failed to attach bus to event loop: %m"); return r; } @@ -720,7 +720,7 @@ static int login_machine(sd_bus *bus, char **args, unsigned n) { &reply2, "u"); if (r < 0) { - log_error_errno(-r, "Failed to retrieve PID of leader: %m"); + log_error_errno(r, "Failed to retrieve PID of leader: %m"); return r; } @@ -730,7 +730,7 @@ static int login_machine(sd_bus *bus, char **args, unsigned n) { master = openpt_in_namespace(leader, O_RDWR|O_NOCTTY|O_CLOEXEC|O_NDELAY); if (master < 0) { - log_error_errno(-master, "Failed to acquire pseudo tty: %m"); + log_error_errno(master, "Failed to acquire pseudo tty: %m"); return master; } @@ -748,7 +748,7 @@ static int login_machine(sd_bus *bus, char **args, unsigned n) { r = sd_bus_open_system_container(&container_bus, args[1]); if (r < 0) { - log_error_errno(-r, "Failed to get container bus: %m"); + log_error_errno(r, "Failed to get container bus: %m"); return r; } @@ -786,13 +786,13 @@ static int login_machine(sd_bus *bus, char **args, unsigned n) { r = pty_forward_new(event, master, &forward); if (r < 0) { - log_error_errno(-r, "Failed to create PTY forwarder: %m"); + log_error_errno(r, "Failed to create PTY forwarder: %m"); return r; } r = sd_event_loop(event); if (r < 0) { - log_error_errno(-r, "Failed to run event loop: %m"); + log_error_errno(r, "Failed to run event loop: %m"); return r; } @@ -1029,7 +1029,7 @@ int main(int argc, char*argv[]) { r = bus_open_transport(arg_transport, arg_host, false, &bus); if (r < 0) { - log_error_errno(-r, "Failed to create bus connection: %m"); + log_error_errno(r, "Failed to create bus connection: %m"); goto finish; } -- cgit v1.2.3-54-g00ecf