From 0f8261015380be71f8a63c8aa37926c2a32d1870 Mon Sep 17 00:00:00 2001 From: Umut Tezduyar Lindskog Date: Wed, 8 Jul 2015 14:35:32 +0200 Subject: property callback returns are consistent It is no different to return 0 over 1 in the property callback. It is confusing to return 1 which made me think 1 has a special purpose. This way code is consistent with the rest of the tree. --- src/network/networkd-network-bus.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) (limited to 'src/network') diff --git a/src/network/networkd-network-bus.c b/src/network/networkd-network-bus.c index b5f8f5cfb2..5717a15327 100644 --- a/src/network/networkd-network-bus.c +++ b/src/network/networkd-network-bus.c @@ -53,11 +53,7 @@ static int property_get_ether_addrs( return r; } - r = sd_bus_message_close_container(reply); - if (r < 0) - return r; - - return 1; + return sd_bus_message_close_container(reply); } const sd_bus_vtable network_vtable[] = { -- cgit v1.2.3-54-g00ecf