From 601185b43da638b1c74153deae01dbd518680889 Mon Sep 17 00:00:00 2001 From: Zbigniew Jędrzejewski-Szmek Date: Sat, 2 Aug 2014 11:12:21 -0400 Subject: Unify parse_argv style getopt is usually good at printing out a nice error message when commandline options are invalid. It distinguishes between an unknown option and a known option with a missing arg. It is better to let it do its job and not use opterr=0 unless we actually want to suppress messages. So remove opterr=0 in the few places where it wasn't really useful. When an error in options is encountered, we should not print a lengthy help() and overwhelm the user, when we know precisely what is wrong with the commandline. In addition, since help() prints to stdout, it should not be used except when requested with -h or --help. Also, simplify things here and there. --- src/notify/notify.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) (limited to 'src/notify') diff --git a/src/notify/notify.c b/src/notify/notify.c index f463c4dd86..2148ae0dfe 100644 --- a/src/notify/notify.c +++ b/src/notify/notify.c @@ -42,8 +42,7 @@ static const char *arg_status = NULL; static bool arg_booted = false; static const char *arg_readahead = NULL; -static int help(void) { - +static void help(void) { printf("%s [OPTIONS...] [VARIABLE=VALUE...]\n\n" "Notify the init system about service status updates.\n\n" " -h --help Show this help\n" @@ -54,8 +53,6 @@ static int help(void) { " --booted Returns 0 if the system was booted up with systemd, non-zero otherwise\n" " --readahead=ACTION Controls read-ahead operations\n", program_invocation_short_name); - - return 0; } static int parse_argv(int argc, char *argv[]) { @@ -85,12 +82,13 @@ static int parse_argv(int argc, char *argv[]) { assert(argc >= 0); assert(argv); - while ((c = getopt_long(argc, argv, "h", options, NULL)) >= 0) { + while ((c = getopt_long(argc, argv, "h", options, NULL)) >= 0) switch (c) { case 'h': - return help(); + help(); + return 0; case ARG_VERSION: puts(PACKAGE_STRING); @@ -131,7 +129,6 @@ static int parse_argv(int argc, char *argv[]) { default: assert_not_reached("Unhandled option"); } - } if (optind >= argc && !arg_ready && -- cgit v1.2.3-54-g00ecf