From 41a598e21a9f6cfe8dad7759c3c9facd55774acf Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Sat, 25 Sep 2010 13:32:54 +0200 Subject: readahead: disable on low memory machines --- src/readahead-collect.c | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) (limited to 'src/readahead-collect.c') diff --git a/src/readahead-collect.c b/src/readahead-collect.c index 937231ca42..fe35da7004 100644 --- a/src/readahead-collect.c +++ b/src/readahead-collect.c @@ -50,6 +50,12 @@ #define MINCORE_VEC_SIZE (READAHEAD_FILE_SIZE_MAX/PAGE_SIZE) +/* fixme: + * + * - detect ssd/lvm/... on btrfs + * - read ahead directories + */ + static int btrfs_defrag(int fd) { struct btrfs_ioctl_vol_args data; @@ -302,10 +308,7 @@ static int collect(const char *root) { ul = fd_first_block(m->fd); if ((k = hashmap_put(files, p, ULONG_TO_PTR(ul))) < 0) { - - if (k != -EEXIST) - log_warning("set_put() failed: %s", strerror(-k)); - + log_warning("set_put() failed: %s", strerror(-k)); free(p); } } @@ -355,7 +358,7 @@ static int collect(const char *root) { if (on_ssd || on_btrfs) { /* On SSD or on btrfs, just write things out in the - * order the files where accessed. */ + * order the files were accessed. */ HASHMAP_FOREACH_KEY(q, p, files, i) pack_file(pack, p, on_btrfs); @@ -442,6 +445,11 @@ int main(int argc, char *argv[]) { log_parse_environment(); log_open(); + if (!enough_ram()) { + log_info("Disabling readahead collector due to low memory."); + return 0; + } + if (collect(argc >= 2 ? argv[1] : "/") < 0) return 1; -- cgit v1.2.3-54-g00ecf