From c3cb6dc20be2bc2b7ee8b9384c6452dc6030fc29 Mon Sep 17 00:00:00 2001 From: Tom Gundersen Date: Thu, 3 Dec 2015 21:26:19 +0100 Subject: resolved: cache - improve logging Some DNS servers will hand out negative answers without SOA records, these can not be cached, so log about that fact. --- src/resolve/resolved-dns-cache.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) (limited to 'src/resolve/resolved-dns-cache.c') diff --git a/src/resolve/resolved-dns-cache.c b/src/resolve/resolved-dns-cache.c index 9ffbf1d1a6..a2cbdd8259 100644 --- a/src/resolve/resolved-dns-cache.c +++ b/src/resolve/resolved-dns-cache.c @@ -443,8 +443,17 @@ int dns_cache_put( dns_cache_remove(c, key); } - if (!answer) + if (!answer) { + _cleanup_free_ char *key_str = NULL; + + r = dns_resource_key_to_string(key, &key_str); + if (r < 0) + return r; + + log_debug("Not caching negative entry without a SOA record: %s", key_str); + return 0; + } for (i = 0; i < answer->n_rrs; i++) dns_cache_remove(c, answer->items[i].rr->key); -- cgit v1.2.3-54-g00ecf