From 880603a13c7ff8a6cab87135dd1eac3f0cd9baab Mon Sep 17 00:00:00 2001 From: Susant Sahani Date: Tue, 27 Oct 2015 09:24:23 +0530 Subject: resolved: port to extract_first_word --- src/resolve/resolved-conf.c | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) (limited to 'src/resolve') diff --git a/src/resolve/resolved-conf.c b/src/resolve/resolved-conf.c index aca0d891c6..22a5c7fdbf 100644 --- a/src/resolve/resolved-conf.c +++ b/src/resolve/resolved-conf.c @@ -22,10 +22,9 @@ #include "conf-parser.h" #include "string-util.h" #include "resolved-conf.h" +#include "extract-word.h" int manager_parse_dns_server(Manager *m, DnsServerType type, const char *string) { - const char *word, *state; - size_t length; DnsServer *first; int r; @@ -34,19 +33,23 @@ int manager_parse_dns_server(Manager *m, DnsServerType type, const char *string) first = type == DNS_SERVER_FALLBACK ? m->fallback_dns_servers : m->dns_servers; - FOREACH_WORD_QUOTED(word, length, string, state) { - char buffer[length+1]; - int family; + for(;;) { + _cleanup_free_ char *word; union in_addr_union addr; bool found = false; DnsServer *s; + int family; + + r = extract_first_word(&string, &word, NULL, 0); + if (r < 0) + return log_error_errno(r, "Failed to parse resolved dns server syntax \"%s\": %m", string); - memcpy(buffer, word, length); - buffer[length] = 0; + if (r == 0) + break; - r = in_addr_from_string_auto(buffer, &family, &addr); + r = in_addr_from_string_auto(word, &family, &addr); if (r < 0) { - log_warning("Ignoring invalid DNS address '%s'", buffer); + log_warning("Ignoring invalid DNS address '%s'", word); continue; } -- cgit v1.2.3-54-g00ecf