From 8333c77edf8fd1654cd96f3f6ee0f078dd64b58b Mon Sep 17 00:00:00 2001 From: Zbigniew Jędrzejewski-Szmek Date: Thu, 28 Mar 2013 09:24:15 -0400 Subject: Always use errno > 0 to help gcc gcc thinks that errno might be negative, and functions could return something positive on error (-errno). Should not matter in practice, but makes an -O4 build much quieter. --- src/shared/calendarspec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/shared/calendarspec.c') diff --git a/src/shared/calendarspec.c b/src/shared/calendarspec.c index cc680779b5..13f70d8e72 100644 --- a/src/shared/calendarspec.c +++ b/src/shared/calendarspec.c @@ -391,7 +391,7 @@ static int prepend_component(const char **p, CalendarComponent **c) { errno = 0; value = strtoul(*p, &e, 10); - if (errno != 0) + if (errno > 0) return -errno; if (e == *p) return -EINVAL; @@ -400,7 +400,7 @@ static int prepend_component(const char **p, CalendarComponent **c) { if (*e == '/') { repeat = strtoul(e+1, &ee, 10); - if (errno != 0) + if (errno > 0) return -errno; if (ee == e+1) return -EINVAL; -- cgit v1.2.3-54-g00ecf