From 2968644080fd103062f070e83edd620e0a58c44d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= Date: Fri, 27 Jun 2014 12:12:07 -0400 Subject: Move x-systemd-device.timeout handling from core to fstab-generator Instead of adjusting job timeouts in the core, let fstab-generator write out a dropin snippet with the appropriate JobTimeout. x-systemd-device.timeout option is removed from Options= line in the generated unit. The functions to write dropins are moved from core/unit.c to shared/dropin.c, to make them available outside of core. generator.c is moved to libsystemd-label, because it now uses functions defined in dropin.c, which are in libsystemd-label. --- src/shared/generator.c | 57 ++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 57 insertions(+) (limited to 'src/shared/generator.c') diff --git a/src/shared/generator.c b/src/shared/generator.c index dcfddaa731..762033bbdf 100644 --- a/src/shared/generator.c +++ b/src/shared/generator.c @@ -28,6 +28,7 @@ #include "unit-name.h" #include "generator.h" #include "path-util.h" +#include "dropin.h" int generator_write_fsck_deps( FILE *f, @@ -86,3 +87,59 @@ int generator_write_fsck_deps( return 0; } + +int generator_write_timeouts(const char *dir, const char *what, const char *where, + const char *opts, char **filtered) { + + /* Allow configuration how long we wait for a device that + * backs a mount point to show up. This is useful to support + * endless device timeouts for devices that show up only after + * user input, like crypto devices. */ + + _cleanup_free_ char *node = NULL, *unit = NULL, *t = NULL; + char *prefix, *start, *timeout, *postfix; + usec_t u; + int r; + size_t len; + + if ((start = mount_test_option(opts, "comment=systemd.device-timeout"))) + timeout = start + 31; + else if ((start = mount_test_option(opts, "x-systemd.device-timeout"))) + timeout = start + 25; + else { + *filtered = strdup(opts); + if (!*filtered) + return log_oom(); + + return 0; + } + + len = strcspn(timeout, ",;" WHITESPACE); + t = strndup(timeout, len); + if (!t) + return -ENOMEM; + + prefix = strndupa(opts, start - opts - (start != opts)); + postfix = timeout + len + (timeout[len] != '\0'); + *filtered = strjoin(prefix, *postfix ? postfix : NULL, NULL); + if (!*filtered) + return log_oom(); + + r = parse_sec(t, &u); + if (r < 0) { + log_warning("Failed to parse timeout for %s, ignoring: %s", + where, timeout); + return 0; + } + + node = fstab_node_to_udev_node(what); + if (!node) + return log_oom(); + + unit = unit_name_from_path(node, ".device"); + if (!unit) + return -ENOMEM; + + return write_drop_in_format(dir, unit, "device-timeout", + "[Unit]\nJobTimeoutSec=%u", u / USEC_PER_SEC); +} -- cgit v1.2.3