From 0a1beeb64207eaa88ab9236787b1cbc2f704ae14 Mon Sep 17 00:00:00 2001 From: Michal Schmidt Date: Fri, 28 Nov 2014 11:58:34 +0100 Subject: treewide: auto-convert the simple cases to log_*_errno() As a followup to 086891e5c1 "log: add an "error" parameter to all low-level logging calls and intrdouce log_error_errno() as log calls that take error numbers", use sed to convert the simple cases to use the new macros: find . -name '*.[ch]' | xargs sed -r -i -e \ 's/log_(debug|info|notice|warning|error|emergency)\("(.*)%s"(.*), strerror\(-([a-zA-Z_]+)\)\);/log_\1_errno(-\4, "\2%m"\3);/' Multi-line log_*() invocations are not covered. And we also should add log_unit_*_errno(). --- src/shared/pager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/shared/pager.c') diff --git a/src/shared/pager.c b/src/shared/pager.c index 001927ce93..572c26b149 100644 --- a/src/shared/pager.c +++ b/src/shared/pager.c @@ -186,7 +186,7 @@ int show_man_page(const char *desc, bool null_stdio) { if (null_stdio) { r = make_null_stdio(); if (r < 0) { - log_error("Failed to kill stdio: %s", strerror(-r)); + log_error_errno(-r, "Failed to kill stdio: %m"); _exit(EXIT_FAILURE); } } -- cgit v1.2.3-54-g00ecf