From 329ac4bc5429cd86c4ac76b13e7e2784f3982760 Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Thu, 30 Apr 2015 11:58:06 +0200 Subject: sd-bus,sd-login: add api for querying the slice within the the user systemd instance of a process units are organized in slice trees, not only for the system instance, but also for user systemd instances, expose this properly. --- src/shared/cgroup-util.c | 72 +++++++++++++++++++++++++++++++----------------- src/shared/cgroup-util.h | 2 ++ 2 files changed, 49 insertions(+), 25 deletions(-) (limited to 'src/shared') diff --git a/src/shared/cgroup-util.c b/src/shared/cgroup-util.c index 67e6f70e8e..dbf7942024 100644 --- a/src/shared/cgroup-util.c +++ b/src/shared/cgroup-util.c @@ -1317,45 +1317,37 @@ static const char *skip_user_manager(const char *p) { return NULL; } -int cg_path_get_user_unit(const char *path, char **ret) { +static const char *skip_user_prefix(const char *path) { const char *e, *t; - char *unit; - int r; assert(path); - assert(ret); - - /* We always have to parse the path from the beginning as unit - * cgroups might have arbitrary child cgroups and we shouldn't get - * confused by those */ /* Skip slices, if there are any */ e = skip_slices(path); - /* Skip the user manager... */ + /* Skip the user manager, if it's in the path now... */ t = skip_user_manager(e); + if (t) + return t; - /* Alternatively skip the user session... */ - if (!t) - t = skip_session(e); - if (!t) - return -ENXIO; + /* Alternatively skip the user session if it is in the path... */ + return skip_session(e); +} - /* ... and skip more slices if there are any */ - e = skip_slices(t); +int cg_path_get_user_unit(const char *path, char **ret) { + const char *t; - r = cg_path_decode_unit(e, &unit); - if (r < 0) - return r; + assert(path); + assert(ret); - /* We skipped over the slices, don't accept any now */ - if (endswith(unit, ".slice")) { - free(unit); + t = skip_user_prefix(path); + if (!t) return -ENXIO; - } - *ret = unit; - return 0; + /* And from here on it looks pretty much the same as for a + * system unit, hence let's use the same parser from here + * on. */ + return cg_path_get_unit(t, ret); } int cg_pid_get_user_unit(pid_t pid, char **unit) { @@ -1487,6 +1479,9 @@ int cg_path_get_slice(const char *p, char **slice) { assert(p); assert(slice); + /* Finds the right-most slice unit from the beginning, but + * stops before we come to the first non-slice unit. */ + for (;;) { size_t n; @@ -1527,6 +1522,33 @@ int cg_pid_get_slice(pid_t pid, char **slice) { return cg_path_get_slice(cgroup, slice); } +int cg_path_get_user_slice(const char *p, char **slice) { + const char *t; + assert(p); + assert(slice); + + t = skip_user_prefix(p); + if (!t) + return -ENXIO; + + /* And now it looks pretty much the same as for a system + * slice, so let's just use the same parser from here on. */ + return cg_path_get_slice(t, slice); +} + +int cg_pid_get_user_slice(pid_t pid, char **slice) { + _cleanup_free_ char *cgroup = NULL; + int r; + + assert(slice); + + r = cg_pid_get_path_shifted(pid, NULL, &cgroup); + if (r < 0) + return r; + + return cg_path_get_user_slice(cgroup, slice); +} + char *cg_escape(const char *p) { bool need_prefix = false; diff --git a/src/shared/cgroup-util.h b/src/shared/cgroup-util.h index 96a3d3bafa..cbf7201370 100644 --- a/src/shared/cgroup-util.h +++ b/src/shared/cgroup-util.h @@ -104,6 +104,7 @@ int cg_path_get_unit(const char *path, char **unit); int cg_path_get_user_unit(const char *path, char **unit); int cg_path_get_machine_name(const char *path, char **machine); int cg_path_get_slice(const char *path, char **slice); +int cg_path_get_user_slice(const char *path, char **slice); int cg_shift_path(const char *cgroup, const char *cached_root, const char **shifted); int cg_pid_get_path_shifted(pid_t pid, const char *cached_root, char **cgroup); @@ -114,6 +115,7 @@ int cg_pid_get_unit(pid_t pid, char **unit); int cg_pid_get_user_unit(pid_t pid, char **unit); int cg_pid_get_machine_name(pid_t pid, char **machine); int cg_pid_get_slice(pid_t pid, char **slice); +int cg_pid_get_user_slice(pid_t pid, char **slice); int cg_path_decode_unit(const char *cgroup, char **unit); -- cgit v1.2.3-54-g00ecf