From c33b329709ebe2755181980a050d02ec7c81ed87 Mon Sep 17 00:00:00 2001 From: Michal Schmidt Date: Fri, 28 Nov 2014 17:09:20 +0100 Subject: treewide: more log_*_errno() conversions, multiline calls Basically: find . -name '*.[ch]' | while read f; do perl -i.mmm -e \ 'local $/; local $_=<>; s/log_(debug|info|notice|warning|error|emergency)\("([^"]*)%s"([^;]*),\s*strerror\(-?([->a-zA-Z_]+)\)\);/log_\1_errno(\4, "\2%m"\3);/gms;print;' \ $f; done Plus manual indentation fixups. --- src/shared/conf-files.c | 4 ++-- src/shared/conf-parser.c | 4 ++-- src/shared/logs-show.c | 3 +-- src/shared/sleep-config.c | 4 ++-- 4 files changed, 7 insertions(+), 8 deletions(-) (limited to 'src/shared') diff --git a/src/shared/conf-files.c b/src/shared/conf-files.c index e6ee97a978..51f4e0105c 100644 --- a/src/shared/conf-files.c +++ b/src/shared/conf-files.c @@ -118,8 +118,8 @@ static int conf_files_list_strv_internal(char ***strv, const char *suffix, const if (r == -ENOMEM) { return r; } else if (r < 0) - log_debug("Failed to search for files in %s: %s", - *p, strerror(-r)); + log_debug_errno(r, "Failed to search for files in %s: %m", + *p); } files = hashmap_get_strv(fh); diff --git a/src/shared/conf-parser.c b/src/shared/conf-parser.c index f9a3459caa..94808fa6ce 100644 --- a/src/shared/conf-parser.c +++ b/src/shared/conf-parser.c @@ -428,8 +428,8 @@ int config_parse(const char *unit, if (r < 0) { if (warn) - log_warning("Failed to parse file '%s': %s", - filename, strerror(-r)); + log_warning_errno(r, "Failed to parse file '%s': %m", + filename); return r; } } diff --git a/src/shared/logs-show.c b/src/shared/logs-show.c index eb15eeac88..16ea1bb782 100644 --- a/src/shared/logs-show.c +++ b/src/shared/logs-show.c @@ -426,8 +426,7 @@ static int output_verbose( else { r = safe_atou64(value, &realtime); if (r < 0) - log_debug("Failed to parse realtime timestamp: %s", - strerror(-r)); + log_debug_errno(r, "Failed to parse realtime timestamp: %m"); } } diff --git a/src/shared/sleep-config.c b/src/shared/sleep-config.c index e6157f0e94..0fd307d0b0 100644 --- a/src/shared/sleep-config.c +++ b/src/shared/sleep-config.c @@ -233,8 +233,8 @@ static bool enough_memory_for_hibernation(void) { r = safe_atollu(active, &act); if (r < 0) { - log_error("Failed to parse Active(anon) from /proc/meminfo: %s: %s", - active, strerror(-r)); + log_error_errno(r, "Failed to parse Active(anon) from /proc/meminfo: %s: %m", + active); return false; } -- cgit v1.2.3-54-g00ecf