From 65d60552f2f1c198df06acef80431cbc460fbab6 Mon Sep 17 00:00:00 2001 From: Jan Engelhardt Date: Wed, 23 Sep 2015 16:55:38 +0200 Subject: sysusers: improve error reporting Creating group input with gid 491. Failed to write files: File exists "Why is the presence of /etc/group a problem?" --- src/sysusers/sysusers.c | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'src/sysusers') diff --git a/src/sysusers/sysusers.c b/src/sysusers/sysusers.c index aaa33354f4..c40f833788 100644 --- a/src/sysusers/sysusers.c +++ b/src/sysusers/sysusers.c @@ -392,11 +392,13 @@ static int write_files(void) { i = hashmap_get(groups, gr->gr_name); if (i && i->todo_group) { + log_error("%s: Group \"%s\" already exists.", group_path, gr->gr_name); r = -EEXIST; goto finish; } if (hashmap_contains(todo_gids, GID_TO_PTR(gr->gr_gid))) { + log_error("%s: Detected collision for GID %d.", group_path, gr->gr_gid); r = -EEXIST; goto finish; } @@ -464,6 +466,7 @@ static int write_files(void) { i = hashmap_get(groups, sg->sg_namp); if (i && i->todo_group) { + log_error("%s: Group \"%s\" already exists.", gshadow_path, sg->sg_namp); r = -EEXIST; goto finish; } @@ -530,11 +533,13 @@ static int write_files(void) { i = hashmap_get(users, pw->pw_name); if (i && i->todo_user) { + log_error("%s: User \"%s\" already exists.", passwd_path, pw->pw_name); r = -EEXIST; goto finish; } if (hashmap_contains(todo_uids, UID_TO_PTR(pw->pw_uid))) { + log_error("%s: Detected collision for UID %d.", passwd_path, pw->pw_uid); r = -EEXIST; goto finish; } -- cgit v1.2.3-54-g00ecf