From 4e5589836c9e143796c3f3d81e67ab7a9209e2b0 Mon Sep 17 00:00:00 2001 From: Martin Pitt Date: Thu, 19 Feb 2015 11:06:24 +0100 Subject: sysv-generator: fix wrong "Overwriting existing symlink" warnings Fix result testing of is_symlink() to ignore negative results, which happen if the file name does not exist at all. In this case we do not want a warning and unlink the non-existing link. https://bugs.debian.org/778700 --- src/sysv-generator/sysv-generator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/sysv-generator') diff --git a/src/sysv-generator/sysv-generator.c b/src/sysv-generator/sysv-generator.c index 2091854e08..bd67f321f6 100644 --- a/src/sysv-generator/sysv-generator.c +++ b/src/sysv-generator/sysv-generator.c @@ -166,7 +166,7 @@ static int generate_unit_file(SysvStub *s) { /* We might already have a symlink with the same name from a Provides:, * or from backup files like /etc/init.d/foo.bak. Real scripts always win, * so remove an existing link */ - if (is_symlink(unit)) { + if (is_symlink(unit) > 0) { log_warning("Overwriting existing symlink %s with real service", unit); (void) unlink(unit); } -- cgit v1.2.3-54-g00ecf