From aa3c5cf8eefa36a3ae727fe136587381e590d333 Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Fri, 22 Mar 2013 17:59:49 +0100 Subject: util: be more picky when validating hostnames No longer allow dots at the beginning or end of host names, Or double dots. https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1152187/comments/14 --- src/test/test-util.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) (limited to 'src/test') diff --git a/src/test/test-util.c b/src/test/test-util.c index cd017ef6fc..08310c83ca 100644 --- a/src/test/test-util.c +++ b/src/test/test-util.c @@ -325,6 +325,19 @@ static void test_bus_path_escape(void) { test_bus_path_escape_one(":1", "_3a1"); } +static void test_hostname_is_valid(void) { + assert(hostname_is_valid("foobar")); + assert(hostname_is_valid("foobar.com")); + assert(!hostname_is_valid("fööbar")); + assert(!hostname_is_valid("")); + assert(!hostname_is_valid(".")); + assert(!hostname_is_valid("..")); + assert(!hostname_is_valid("foobar.")); + assert(!hostname_is_valid(".foobar")); + assert(!hostname_is_valid("foo..bar")); + assert(!hostname_is_valid("xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx")); +} + int main(int argc, char *argv[]) { test_streq_ptr(); test_first_word(); @@ -349,6 +362,7 @@ int main(int argc, char *argv[]) { test_default_term_for_tty(); test_memdup_multiply(); test_bus_path_escape(); + test_hostname_is_valid(); return 0; } -- cgit v1.2.3-54-g00ecf