From 9091e686f43184065381aa71929e3df36a4ea2e1 Mon Sep 17 00:00:00 2001 From: Thomas Hindoe Paaboel Andersen Date: Sat, 14 Dec 2013 13:09:07 +0100 Subject: Add more _printf_'s for format-nonliterals Clang is a bit more strict wrt format-nonliterals: http://clang.llvm.org/docs/LanguageExtensions.html#format-string-checking Adding these extra printf attributes also makes gcc able to find more problems. E.g. this patch uncovers a format issue in udev-builtin-path_id.c Some parts looked intetional about breaking the format-nonliteral check. I added some supression for warnings there. --- src/udev/scsi_id/scsi_id.c | 1 + 1 file changed, 1 insertion(+) (limited to 'src/udev/scsi_id') diff --git a/src/udev/scsi_id/scsi_id.c b/src/udev/scsi_id/scsi_id.c index c2cc2ea48d..ae36b9e356 100644 --- a/src/udev/scsi_id/scsi_id.c +++ b/src/udev/scsi_id/scsi_id.c @@ -67,6 +67,7 @@ static char model_enc_str[256]; static char revision_str[16]; static char type_str[16]; +_printf_(6,0) static void log_fn(struct udev *udev, int priority, const char *file, int line, const char *fn, const char *format, va_list args) -- cgit v1.2.3-54-g00ecf