From 57ce4bd4ea3c54317490ad719fad17bc6413c3f6 Mon Sep 17 00:00:00 2001 From: Zbigniew Jędrzejewski-Szmek Date: Tue, 30 Oct 2012 09:35:53 +0100 Subject: coredumpctl: add guard to options table It is not nice to segfault on unknown options :( --- src/journal/coredumpctl.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) (limited to 'src') diff --git a/src/journal/coredumpctl.c b/src/journal/coredumpctl.c index 311c18b6ab..3560534bf6 100644 --- a/src/journal/coredumpctl.c +++ b/src/journal/coredumpctl.c @@ -143,10 +143,11 @@ static int parse_argv(int argc, char *argv[]) { int r, c; static const struct option options[] = { - { "help", no_argument, NULL, 'h' }, - { "version" , no_argument, NULL, ARG_VERSION }, - { "no-pager", no_argument, NULL, ARG_NO_PAGER }, - { "output", required_argument, NULL, 'o' }, + { "help", no_argument, NULL, 'h' }, + { "version" , no_argument, NULL, ARG_VERSION }, + { "no-pager", no_argument, NULL, ARG_NO_PAGER }, + { "output", required_argument, NULL, 'o' }, + { NULL, 0, NULL, 0 } }; assert(argc >= 0); @@ -183,6 +184,10 @@ static int parse_argv(int argc, char *argv[]) { } break; + + case '?': + return -EINVAL; + default: log_error("Unknown option code %c", c); return -EINVAL; -- cgit v1.2.3-54-g00ecf