From eb8b496e890de4ba347f78f0e7e978117ab2a479 Mon Sep 17 00:00:00 2001 From: Russell Coker Date: Tue, 5 Dec 2006 14:32:44 +0100 Subject: SELinux: label created symlink instead of node The current code will label the target of a symlink rather than the link itself. This means that the link does not get it's context set and the target gets the wrong context. Incidentally this affects the labelling of hard disk device nodes and can get in the way of booting. Also get_media() should not be called with devname==NULL. --- udev_selinux.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) (limited to 'udev_selinux.c') diff --git a/udev_selinux.c b/udev_selinux.c index b802e1fc6e..a305e24136 100644 --- a/udev_selinux.c +++ b/udev_selinux.c @@ -90,10 +90,13 @@ void selinux_setfilecon(const char *file, const char *devname, unsigned int mode char *media; int ret = -1; - media = get_media(devname, mode); - if (media) { - ret = matchmediacon(media, &scontext); - free(media); + if(devname) + { + media = get_media(devname, mode); + if (media) { + ret = matchmediacon(media, &scontext); + free(media); + } } if (ret < 0) @@ -102,7 +105,7 @@ void selinux_setfilecon(const char *file, const char *devname, unsigned int mode return; } - if (setfilecon(file, scontext) < 0) + if (lsetfilecon(file, scontext) < 0) err("setfilecon %s failed: %s", file, strerror(errno)); freecon(scontext); -- cgit v1.2.3-54-g00ecf