0016_pid_file_lock_creation_mask.dpatch by Sam Hocevar <sam@zoy.org> pid_file_lock is created with a mask of 644 instead of 0644. This patch fixes this octal/decimal confusion as well as the (harmless) one in the previous umask() call. diff -urNad trunk~/saslauthd/saslauthd-main.c trunk/saslauthd/saslauthd-main.c --- trunk~/saslauthd/saslauthd-main.c 2006-05-29 22:52:42.000000000 +0300 +++ trunk/saslauthd/saslauthd-main.c 2007-06-26 12:07:10.000000000 +0300 @@ -276,7 +276,7 @@ exit(1); } - umask(077); + umask(0077); pid_file_size = strlen(run_path) + sizeof(PID_FILE_LOCK) + 1; if ((pid_file_lock = malloc(pid_file_size)) == NULL) { @@ -287,7 +287,7 @@ strlcpy(pid_file_lock, run_path, pid_file_size); strlcat(pid_file_lock, PID_FILE_LOCK, pid_file_size); - if ((pid_file_lock_fd = open(pid_file_lock, O_CREAT|O_TRUNC|O_RDWR, 644)) < 0) { + if ((pid_file_lock_fd = open(pid_file_lock, O_CREAT|O_TRUNC|O_RDWR, 0644)) < 0) { rc = errno; logger(L_ERR, L_FUNC, "could not open pid lock file: %s", pid_file_lock); logger(L_ERR, L_FUNC, "open: %s", strerror(rc));