From 339fb3bc032b9f35b07b90480ae82a0fd352e078 Mon Sep 17 00:00:00 2001 From: Jan Lindemann Date: Thu, 30 Aug 2012 18:09:10 +0000 Subject: Replace xf86UnMapVidMem with pci_device_unmap_range Mixing pci_device_map_range with xf86UnMapVidMem doesn't work too well. X.Org bug#18028 Bug found by Bryan Henderson Signed-off-by: Julien Cristau --- diff --git a/src/sis_driver.c b/src/sis_driver.c index 61e8075..4c9b9cb 100644 --- a/src/sis_driver.c +++ b/src/sis_driver.c @@ -7344,7 +7344,11 @@ SISUnmapMem(ScrnInfoPtr pScrn) if(pSiSEnt->MapCountIOBase) { pSiSEnt->MapCountIOBase--; if((pSiSEnt->MapCountIOBase == 0) || (pSiSEnt->forceUnmapIOBase)) { +#ifndef XSERVER_LIBPCIACCESS xf86UnMapVidMem(pScrn->scrnIndex, (pointer)pSiSEnt->IOBase, (pSiS->mmioSize * 1024)); +#else + pci_device_unmap_range(pSiS->PciInfo, pSiSEnt->IOBase, (pSiS->mmioSize * 1024)); +#endif pSiSEnt->IOBase = NULL; pSiSEnt->MapCountIOBase = 0; pSiSEnt->forceUnmapIOBase = FALSE; @@ -7355,7 +7359,11 @@ SISUnmapMem(ScrnInfoPtr pScrn) if(pSiSEnt->MapCountIOBaseDense) { pSiSEnt->MapCountIOBaseDense--; if((pSiSEnt->MapCountIOBaseDense == 0) || (pSiSEnt->forceUnmapIOBaseDense)) { +#ifndef XSERVER_LIBPCIACCESS xf86UnMapVidMem(pScrn->scrnIndex, (pointer)pSiSEnt->IOBaseDense, (pSiS->mmioSize * 1024)); +#else + pci_device_unmap_range(pSiS->PciInfo, (pointer)pSiSEnt->IOBaseDense, (pSiS->mmioSize * 1024)); +#endif pSiSEnt->IOBaseDense = NULL; pSiSEnt->MapCountIOBaseDense = 0; pSiSEnt->forceUnmapIOBaseDense = FALSE; @@ -7366,7 +7374,11 @@ SISUnmapMem(ScrnInfoPtr pScrn) if(pSiSEnt->MapCountFbBase) { pSiSEnt->MapCountFbBase--; if((pSiSEnt->MapCountFbBase == 0) || (pSiSEnt->forceUnmapFbBase)) { +#ifndef XSERVER_LIBPCIACCESS xf86UnMapVidMem(pScrn->scrnIndex, (pointer)pSiSEnt->RealFbBase, pSiS->FbMapSize); +#else + pci_device_unmap_range(pSiS->PciInfo, (pointer)pSiSEnt->RealFbBase, pSiS->FbMapSize); +#endif pSiSEnt->FbBase = pSiSEnt->RealFbBase = NULL; pSiSEnt->MapCountFbBase = 0; pSiSEnt->forceUnmapFbBase = FALSE; @@ -7376,13 +7388,25 @@ SISUnmapMem(ScrnInfoPtr pScrn) } } else { #endif +#ifndef XSERVER_LIBPCIACCESS xf86UnMapVidMem(pScrn->scrnIndex, (pointer)pSiS->IOBase, (pSiS->mmioSize * 1024)); +#else + pci_device_unmap_range(pSiS->PciInfo, (pointer)pSiS->IOBase, (pSiS->mmioSize * 1024)); +#endif pSiS->IOBase = NULL; #ifdef __alpha__ +#ifndef XSERVER_LIBPCIACCESS xf86UnMapVidMem(pScrn->scrnIndex, (pointer)pSiS->IOBaseDense, (pSiS->mmioSize * 1024)); +#else + pci_device_unmap_range(pSiS->PciInfo, (pointer)pSiS->IOBaseDense, (pSiS->mmioSize * 1024)); +#endif pSiS->IOBaseDense = NULL; #endif +#ifndef XSERVER_LIBPCIACCESS xf86UnMapVidMem(pScrn->scrnIndex, (pointer)pSiS->RealFbBase, pSiS->FbMapSize); +#else + pci_device_unmap_range(pSiS->PciInfo, (pointer)pSiS->RealFbBase, pSiS->FbMapSize); +#endif pSiS->FbBase = pSiS->RealFbBase = NULL; #ifdef SISDUALHEAD } -- cgit v0.9.0.2-2-gbebe From 926d4f655c8491b68a338f50c810f6729686ec9f Mon Sep 17 00:00:00 2001 From: Adam Jackson Date: Tue, 25 Sep 2012 12:54:51 +0000 Subject: Remove mibstore.h Signed-off-by: Adam Jackson --- diff --git a/src/sis_driver.c b/src/sis_driver.c index 4c9b9cb..46cfefd 100644 --- a/src/sis_driver.c +++ b/src/sis_driver.c @@ -57,7 +57,6 @@ #include "fb.h" #include "micmap.h" #include "mipointer.h" -#include "mibstore.h" #include "edid.h" #define SIS_NEED_inSISREG @@ -8883,7 +8882,6 @@ SISScreenInit(SCREEN_INIT_ARGS_DECL) } pSiS->SiSFastVidCopyDone = TRUE; - miInitializeBackingStore(pScreen); xf86SetBackingStore(pScreen); xf86SetSilkenMouse(pScreen); -- cgit v0.9.0.2-2-gbebe From 7d4402786b758de3e6ce2641e15a39d612d5c518 Mon Sep 17 00:00:00 2001 From: Adam Jackson Date: Mon, 15 Oct 2012 23:11:30 +0000 Subject: Stop including xf86Priv.h As the name might suggest, it's server-private. Signed-off-by: Adam Jackson --- diff --git a/src/sis.h b/src/sis.h index 46fca2a..20e6134 100644 --- a/src/sis.h +++ b/src/sis.h @@ -75,7 +75,6 @@ #include "compiler.h" #include "xf86Pci.h" -#include "xf86Priv.h" #include "xf86_OSproc.h" #if GET_ABI_MAJOR(ABI_VIDEODRV_VERSION) < 6 #include "xf86Resources.h" diff --git a/src/sis_driver.c b/src/sis_driver.c index 46cfefd..cefe503 100644 --- a/src/sis_driver.c +++ b/src/sis_driver.c @@ -93,6 +93,10 @@ #include "dri.h" #endif +#ifndef DEFAULT_DPI +#define DEFAULT_DPI 96 +#endif + /* * LookupWindow was removed with video abi 11. */ -- cgit v0.9.0.2-2-gbebe