summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDieter Plaetinck <dieter@plaetinck.be>2008-12-16 19:00:40 +0100
committerDieter Plaetinck <dieter@plaetinck.be>2008-12-16 19:00:40 +0100
commit303a52a1af49db280d8d364aedc477e6f4316189 (patch)
tree4e91ebbaaf8b60568c8b569751b05e900bc80e67
parent21c845616778c108b9a438291d01755c651c9c84 (diff)
fix for duplicate lv's when removing an other lv
-rw-r--r--TODO1
-rw-r--r--src/core/libs/lib-ui-interactive.sh4
2 files changed, 2 insertions, 3 deletions
diff --git a/TODO b/TODO
index 2ccd0a8..2b284f9 100644
--- a/TODO
+++ b/TODO
@@ -12,7 +12,6 @@ ALPHA PHASE: get some people to test and suggest ideas, while fixing bugs and re
* find a way to make _cli_ask_checklist still userfriendly for long lists.. maybe we should just propose/ask to use dia if the list is too long
* lib things sometimes call die_error but we go back to the menu.. or something.. i think
* automatically configure grub for dm_crypt and lvm
-* removing an LV from a VG with more then 1 LV makes another LV be listed twice
* when removing dm_mapper devices, their "results" are not cleaned up (eg remove a LV filesystem on a VG and the LV block device remains)
diff --git a/src/core/libs/lib-ui-interactive.sh b/src/core/libs/lib-ui-interactive.sh
index 8241996..4b7e273 100644
--- a/src/core/libs/lib-ui-interactive.sh
+++ b/src/core/libs/lib-ui-interactive.sh
@@ -474,7 +474,7 @@ interactive_filesystems() {
fi
fi
else
- # an existing LV will be edited and it's settings updated #TODO: if we have 2 LV's, and we delete one, the result is twice the other lv
+ # an existing LV will be edited and it's settings updated
for lv in `sed 's/|/ /g' <<< $fs`
do
label=$(cut -d ';' -f 6 <<< $lv)
@@ -494,8 +494,8 @@ interactive_filesystems() {
else
add=
fi
- [ -n "$add" -a -z "$newfs" ] && newfs=$add
[ -n "$add" -a -n "$newfs" ] && newfs="$newfs|$add"
+ [ -n "$add" -a -z "$newfs" ] && newfs=$add
done
fs=$newfs
fi