summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDieter Plaetinck <dieter@plaetinck.be>2008-12-16 21:22:38 +0100
committerDieter Plaetinck <dieter@plaetinck.be>2008-12-16 21:22:38 +0100
commit46975b0668ceb76bbf1283a4bf7bf30e8b9d5142 (patch)
tree36e8787efae8b0e6776c6988471ee43f706a8712
parent5bb94e2a56a295c8323e4a923497f8f5d9e94f39 (diff)
todo updates
-rw-r--r--TODO2
-rw-r--r--src/core/libs/lib-ui-interactive.sh2
2 files changed, 2 insertions, 2 deletions
diff --git a/TODO b/TODO
index 2b284f9..80cfe35 100644
--- a/TODO
+++ b/TODO
@@ -12,7 +12,7 @@ ALPHA PHASE: get some people to test and suggest ideas, while fixing bugs and re
* find a way to make _cli_ask_checklist still userfriendly for long lists.. maybe we should just propose/ask to use dia if the list is too long
* lib things sometimes call die_error but we go back to the menu.. or something.. i think
* automatically configure grub for dm_crypt and lvm
-* when removing dm_mapper devices, their "results" are not cleaned up (eg remove a LV filesystem on a VG and the LV block device remains)
+* when removing lvm LV's, their "resulting" volumes are not cleaned up because of a label issue
BETA PHASE: try to get aif on the (beta) installcd as an experimental, alternative installer.
diff --git a/src/core/libs/lib-ui-interactive.sh b/src/core/libs/lib-ui-interactive.sh
index d968d27..dd3e9b0 100644
--- a/src/core/libs/lib-ui-interactive.sh
+++ b/src/core/libs/lib-ui-interactive.sh
@@ -379,7 +379,7 @@ interactive_filesystem ()
new_device=
[ "$fs_type" = lvm-vg ] && new_device="/dev/mapper/$fs_label $fs_type $fs_label"
[ "$fs_type" = lvm-pv ] && new_device="$part+ $fs_type no_label"
- [ "$fs_type" = lvm-lv ] && new_device="/dev/mapper/$part_label-$fs_label $fs_type $fs_label"
+ [ "$fs_type" = lvm-lv ] && new_device="/dev/mapper/$part_label-$fs_label $fs_type $fs_label" #TODO: we get entries like '/dev/mapper/myvg-mylv lvm-lv no_label' wtf?? this causes deletion (see below) to break
[ "$fs_type" = dm_crypt ] && new_device="/dev/mapper/$fs_label $fs_type no_label"
[ -n "$new_device" ] && ! grep -q "^$new_device " $TMP_BLOCKDEVICES && echo "$new_device no_fs" >> $TMP_BLOCKDEVICES
fi