diff options
| author | Dieter Plaetinck <dieter@plaetinck.be> | 2008-12-09 19:40:59 +0100 |
|---|---|---|
| committer | Dieter Plaetinck <dieter@plaetinck.be> | 2008-12-09 19:40:59 +0100 |
| commit | 2d414a8b2adcf23215500cbe73b88c21bdc14dbb (patch) | |
| tree | f8d8337ba884f2254fbf83b0eb758de8185fb5a7 | |
| parent | e85161045759c0931329900b062c1f64ceedfc85 (diff) | |
hang bug in manual FS stuff + some small stuff
| -rw-r--r-- | TODO | 3 | ||||
| -rw-r--r-- | src/core/libs/lib-blockdevices-filesystems.sh | 6 | ||||
| -rw-r--r-- | src/core/libs/lib-ui-interactive.sh | 6 |
3 files changed, 9 insertions, 6 deletions
@@ -9,7 +9,7 @@ General: * test refactored disk code Specifically: -* lib/blockdevice: last partition/home in autoprepare does not get created +* lib/blockdevice: autoprepare does not take the last item in 'for fsspec in $STRING; do' (check debug output) * core/interactive: gui transparancy: interactive autoprepare, package selection * core/interactive: fix workaround needed for installpkg exitcode * core/interactive: keymap setting from installer does not go in $target/etc/rc.conf @@ -17,6 +17,7 @@ Specifically: * core/base: implement as specified in README * core/quickinst: figure out what needs to be done and do it. * find a way to make _cli_ask_checklist still userfriendly for long lists.. maybe we should just propose/ask to use dia if the list is too long +* lib things sometimes call die_error but we go back to the menu.. or something.. i think BETA PHASE: try to get aif on the (beta) installcd as an experimental, alternative installer. * involve broader community diff --git a/src/core/libs/lib-blockdevices-filesystems.sh b/src/core/libs/lib-blockdevices-filesystems.sh index 980c196..2934660 100644 --- a/src/core/libs/lib-blockdevices-filesystems.sh +++ b/src/core/libs/lib-blockdevices-filesystems.sh @@ -55,7 +55,7 @@ target_special_fs () } -# taken from setup +# taken from setup #TODO: we should be able to not need this function # Disable swap and all mounted partitions for the destination system. Unmount # the destination root partition last! TODO: only taking care of / is not enough, we can have the same problem on another level (eg /a/b/c and /a/b) target_umountall() @@ -284,6 +284,8 @@ partition() target_umountall # setup input var for sfdisk + # format: each line=1 part. <start> <size> <id> <bootable>[ <c,h,s> <c,h,s>] + for fsspec in $STRING; do fssize=$(echo $fsspec | tr -d ' ' | cut -f1 -d:) fssize_spec=",$fssize" @@ -300,7 +302,7 @@ partition() sfdisk_input="${sfdisk_input}${fssize_spec}${fstype_spec}${bootflag_spec}\n" done - sfdisk_input=$(printf "$sfdisk_input") + sfdisk_input=$(printf "$sfdisk_input") # convert \n to newlines # invoke sfdisk debug "Partition calls: sfdisk $DEVICE -uM >$LOG 2>&1 <<< $sfdisk_input" diff --git a/src/core/libs/lib-ui-interactive.sh b/src/core/libs/lib-ui-interactive.sh index c381837..c2c7300 100644 --- a/src/core/libs/lib-ui-interactive.sh +++ b/src/core/libs/lib-ui-interactive.sh @@ -475,9 +475,9 @@ interactive_filesystems() { errors= warnings= - grep -q ';/boot;' || warnings="$warnings\n-No separate /boot filesystem" - grep -q ';/;' || errors="$errors\n-No filesystem with mountpoint /" - grep -q ' swap;' || grep -q '|swap;' || warnings="$warnings\n-No swap partition defined" + grep -q ';/boot;' $TMP_BLOCKDEVICES || warnings="$warnings\n-No separate /boot filesystem" + grep -q ';/;' $TMP_BLOCKDEVICES || errors="$errors\n-No filesystem with mountpoint /" + grep -q ' swap;' $TMP_BLOCKDEVICES || grep -q '|swap;' $TMP_BLOCKDEVICES || warnings="$warnings\n-No swap partition defined" if [ -n "$errors$warnings" ] then |