summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--TODO2
-rw-r--r--src/core/libs/lib-blockdevices-filesystems.sh1
2 files changed, 2 insertions, 1 deletions
diff --git a/TODO b/TODO
index 3e2060d..3ba8cf7 100644
--- a/TODO
+++ b/TODO
@@ -14,7 +14,7 @@ ALPHA PHASE: get some people to test and suggest ideas, while fixing bugs and re
* test fancy dm_crypt/lvm etc setups
* automatically configure grub for dm_crypt and lvm
* cannot destruct luks devices (cryptsetup isLuks exits 234 instead of 0 for the device) -> breaks rollback when you have a luks FS
-* rollback sometimes loops only once (eg with lvm setup only the LV is rolled back)
+* rollback sometimes loops only once (eg with lvm setup only the LV is rolled back). open_items=1 doesn't get set even though it skips stuff (like the VG)
BETA PHASE: try to get aif on the (beta) installcd as an experimental, alternative installer.
* find a way to not have to preload libs and stuff, only load them when needed. -> faster start of install program
diff --git a/src/core/libs/lib-blockdevices-filesystems.sh b/src/core/libs/lib-blockdevices-filesystems.sh
index 4151c36..fd3c741 100644
--- a/src/core/libs/lib-blockdevices-filesystems.sh
+++ b/src/core/libs/lib-blockdevices-filesystems.sh
@@ -572,6 +572,7 @@ rollback_filesystems ()
for i in `awk '$2 ~ /dm_crypt/ {print $1}' $TMP_BLOCKDEVICES`; do cryptsetup isLuks $i >/dev/null && have_crypt=1; done
# TODO: Find a way to determine if a volume is used for a dm_crypt device.
# this is a workaround that checks if any of the specified dm_crypts is still active. These devices may not be using this lvm LV, but we don't do much harm in skipping anyway. The dm_crypts should be cleared otherwise there's a problem anyway.
+ # TODO: beware though. isLuks can exit(234) even though the volume isLuks .. :s
if [ $have_crypt -gt 0 ]
then
debug "$part ->Cannot do right now..."