From 9f34485bed2aa77e312575dc0217d9ad672755d4 Mon Sep 17 00:00:00 2001 From: Dieter Plaetinck Date: Sun, 12 Dec 2010 19:59:14 +0100 Subject: cleanup some TODO's and other cruft --- src/core/procedures/automatic | 13 ++++++------- src/core/procedures/base | 6 ++---- 2 files changed, 8 insertions(+), 11 deletions(-) (limited to 'src/core/procedures') diff --git a/src/core/procedures/automatic b/src/core/procedures/automatic index 6fdc1d8..6aa69b9 100644 --- a/src/core/procedures/automatic +++ b/src/core/procedures/automatic @@ -1,18 +1,17 @@ #!/bin/bash -# This is a procedure for automatic deployment/installation/configuration of systems. # TODO: document! (readme, notes about deployment profiles, examples, ...) +# This is a procedure for automatic deployment/installation/configuration of systems. # check /usr/share/aif/examples for some example config files. # This procedure can easily replace the old quickinst script if you look at the "generic install" config file # Look at the base procedure to see the phases and which workers they'll execute. # It should be: # phase_preparation=(configure intro sysprep select_source runtime_network runtime_repositories runtime_packages) # phase_basics=(set_clock prepare_disks) -# phase_system=(package_list install_packages auto_fstab auto_networkTODO auto_locale auto_keymap_font configure_system mkinitcpio locales install_bootloader) +# phase_system=(package_list install_packages auto_fstab auto_network auto_locale auto_keymap_font configure_system mkinitcpio locales install_bootloader) # phase_finish=(msg_report) # In theory, the only manual thing should maybe be configuring the runtime network and putting the configfile in place -# TODO: I don't know if you can do non-interactive dm_crypt stuff.. maybe by pulling luks keyfiles from svn/git/..? -# TODO: for worker_configure_system, we probably want the user to specify hostname, root pass etc. -# TODO: implement setting hostname, keymap, consolefont, network settings +# I don't know if you can do non-interactive dm_crypt stuff.. maybe by pulling luks keyfiles from svn/git/..? +# TODO: implement setting hostname, keymap, consolefont, network settings, root pass, etc # for a list of recognized variables, see examples/generic-install-on-sda depend_procedure core base @@ -110,7 +109,7 @@ worker_package_list () worker_install_packages () { - target_prepare_pacman core extra community #TODO: it would be better if this was a separate worker, i think + target_prepare_pacman core extra community installpkg } @@ -123,7 +122,7 @@ worker_set_clock () worker_auto_network () { - # temporary override because i need to implement this + #TODO implement this true } diff --git a/src/core/procedures/base b/src/core/procedures/base index 98a816b..d57a625 100644 --- a/src/core/procedures/base +++ b/src/core/procedures/base @@ -1,6 +1,6 @@ #!/bin/bash -#TODO: make this profile work on itself, eg some stuff from inheriting profiles should be moved in, stuff implemented etc +# this procedure is meant to be inherited from var_DEFAULTFS="/boot:32:ext2:+ swap:256:swap /:7500:ext3 /home:*:ext3" var_TARGET_DIR="/mnt" # When overriding this, do _not_ add a trailing /. It's not needed and maybe you could even break something var_RUNTIME_REPOSITORIES= # array like this ('name1' 'location of repo 1' ['name2' 'location of repo2',..]) @@ -153,7 +153,7 @@ worker_package_list () worker_install_packages () { - target_prepare_pacman core #TODO: it would be better if this was a separate worker, i think + target_prepare_pacman core installpkg } @@ -186,7 +186,6 @@ worker_auto_keymap_font () worker_configure_system () { - #TODO: what to do here? true } @@ -211,7 +210,6 @@ worker_initialtime () worker_install_bootlader () { - #TODO: ask which disk, install grub on it true } -- cgit v1.2.3-54-g00ecf